Handle ands #26
Open
Handle ands #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ucturing, no useless else, line breaks in destructured params, prefer spread) - Linting (ESLint): Add ignore file in conjunction with linting all by default (catches index.js) - npm: Update eslinting devDeps to latest major versions - npm: Update spdx-correct, and spdx-satisfies to latest major versions - npm: Update other deps. to latest minor version - Travis: Update per newest minimum (and add 10 and 12)
|
@delfrrr : Are you still maintaining? Do you want a collaborator to be able to make updates? I'm pretty busy, but would like to get those PRs merged and what not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #25.
It seems to me that the argument order here is reversed.
For example, without this
getLicenseTypewas getting "permissive" for(GPL-3.0 AND MIT).With the fix it gets "uncategorized" (which is better than "permissive", though I hope this could be improved later to suggest "protective").
I think the reason this might not have been noticed is that it can work ok with comparing licenses for identity.