fix: resolution of git remotes #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sgitario
force-pushed
the
1007_git_remotes
branch
from
fece5b4
to
6b101e9
Compare
Once the first git remote is found, we iterate over all the values and overwrite the values. For example, having: ``` [remote "origin"] url = [email protected]:Sgitario/dekorate.git fetch = +refs/heads/*:refs/remotes/origin/* [remote "upstream"] url = [email protected]:dekorateio/dekorate.git fetch = +refs/heads/*:refs/remotes/upstream/* [remote "auri"] url = https://github.com/aureamunoz/dekorate fetch = +refs/heads/*:refs/remotes/auri/* ``` Will produce a map of only an entry with: ``` 'remote "origin"': https://github.com/aureamunoz/dekorate ``` Because https://github.com/aureamunoz/dekorate, it's the last value. Also, the logic about remotes need to be aligned with this in the TektonManifestGenerator.
Sgitario
force-pushed
the
1007_git_remotes
branch
from
6b101e9
to
172d27e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once the first git remote is found, we iterate over all the values and overwrite the values.
For example, having:
Will produce a map of only an entry with:
Because https://github.com/aureamunoz/dekorate, it's the last value.
Also, the logic about remotes need to be aligned with this in the TektonManifestGenerator.