forked from elastic/kibana
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Show underlying data embeddable #15
Closed
drewdaemon
wants to merge
141
commits into
dej611:feature/show-underlying-data
from
drewdaemon:show-underlying-data-embeddable
Closed
Changes from 6 commits
Commits
Show all changes
141 commits
Select commit
Hold shift + click to select a range
7dbedb9
starting to gather necessary data in embeddable
drewdaemon 10b88d5
Computing view underlying data args
drewdaemon 52997f6
working now
drewdaemon 5792deb
Add compatibility check for action
drewdaemon 9661db2
Move action creator to own module
drewdaemon 7c6d314
[Fleet] Retry Saved Object import on conflict error (#126900)
hop-dev 3c90147
[Console] Support auto-complete for data streams (#126235)
mibragimov c9e66b8
[Cloud Posture] add filterting for benchmark (#126980)
CohenIdo bc0d9e7
[Presentation] Fix some bugs with services dependency injection (#126…
f12891e
:bug: Handle case of undefined fitting for line/area (#126891)
dej611 0807b53
fix data view load err msg (#126974)
mattkime 0adb328
[data views] Reenable data view validation functional test (#125892)
mattkime 8b82657
[data views] functional tests to typescript (#126977)
mattkime d0b64d9
[ML] Add API tests for analytics jobs_exist and new_job_caps endpoint…
peteharverson 3fe1270
[Lens][Embeddable] Make Embeddable resilient when toggling actions (#…
dej611 04f956d
[Cloud Posture] Update cloud security posture code owners (#127004)
ari-aviran d5a1cdc
[App Search] Add an audit modal to show last changes on a modal. (#12…
efegurkan 90f0d8d
[Reporting] Use the logger from Core instead of a wrapper (#126740)
tsullivan a79562a
[SecuritySolution] Alerts table Fields Browser revamp (#126105)
semd eca203c
[AggConfigs] Add TopMetrics agg (#125936)
Dosant 73f7ac4
Fix Pagination is not working correctly for host by risk under hosts …
machadoum 004f0d4
[type-summarizer/integration] fix flaky tests (#127038)
a4febd7
Allow access to ElasticsearchClient's child function from core's TS i…
mikecote 23ac12b
[Workplace Search] Connect button no longer gets stuck on connection …
sphilipse f47f89b
[Workplace Search] Make SharePoint Online users start with the Oauth …
sphilipse ccf16e9
[Security Solution] Add metadta doc and capabilities to telemetry (#1…
kevinlog 8a8bfd5
[Maps] Fixed double click issue when deleting a shape (#124661)
maksimkovalev f85f809
Add retries (#126480)
qn895 fd55bbd
Marking more methods on the alerting task runner as private (#124546)
kobelb ff90bd4
Use execution context for Fullstory (#126780)
935fcc2
skip flaky suite (#126658)
mistic b2e419d
[Reporting] Improve error logging for rescheduled jobs (#126737)
tsullivan 629e0f3
skip flaky suite (#126027)
mistic 0640782
[ML] Adding data recognizer module config cache (#126338)
jgowdyelastic de3ae9b
Remove License Requirement for Enterprise Search App Search Meta Engi…
markjhoy a24b1fc
Don't submit empty seed_urls or sitemap_urls when making a partial cr…
cb70888
[Telemetry] Check permissions when requesting telemetry (#126238)
afharo c0a653d
[Alerting] Adding functional tests for alerting and actions telemetry…
ymao1 2c7fe22
Revert "[CI] Expand spot instance trial a bit (#126928)"
brianseeders 9b79234
Revert "[ci] Configure hourly pipeline for a small spot instance tria…
brianseeders be7ff2c
[type-summarizer] always use normalized paths, fix windows compat (#1…
0821c31
[ftr] implement support for accessing ES through CCS (#126547)
2f83c65
Fix session cleanup test (#126966)
jportner 18a5344
[Security Solution][Rules] - Remove rule selection for read only user…
yctercero 50ba761
[Security Solution][Lists] - Updates exception flyout edit error mess…
yctercero e86d7ae
[Security Solution][Lists] - Add missing privileges callout to except…
yctercero 962347f
[Lens] Fixed flakiness on runtime fields' appearance on the list (#12…
stratoula fc3aedc
Hide Enterprise search panel when no nodes are present (#127100)
matschaffer 5ad355e
Remove all cases related code from timelines (#127003)
academo 720fbed
[Gauge] Vis editors gauge legacy percent mode. (#126318)
Kuznietsov 813ba85
Fix copy and pasted renderer user_name test (#126663)
machadoum dd4652b
APM Synthtrace: Introduce new DSL using generators (#123454)
Mpdreamz bf12417
[Security Solution] Add User Risk tab to Users page (#126434)
machadoum d7c26c1
create rules config based on rules status and update package policy (…
CohenIdo a5f410e
[Stack Monitoring] add back api integration tests and update esArchiv…
neptunian 7936381
[Cloud Posture] Add blank page graphic (#126750)
ari-aviran 0a06242
removes flakiness from prebuilt rules (#127137)
MadameSheema 1f514d7
[eslint] automatically determine dev packages (#127089)
015be5f
Update babel (main) (#126871)
renovate[bot] be0bd54
[APM] set default value for Infrastructure View flag to false (#127127)
MiriamAparicio 8e383bd
[Reporting] Copy updates for warning notifications (#126562)
jloleysens 3dd05d6
unksips cypress creation (#127024)
MadameSheema 5cab9e8
[Cases] Add docs for new hooks (#127133)
academo a76fef1
Stop showing the warning toast during security solution cypress tests…
kqualters-elastic ed4c19c
Use debounce instead of async url update to remove app state from URL…
ThomThomson 192309f
Typescript upgrade to 4.6.2 (#126935)
6c4e208
make getViewUnderlyingDataArgs synchronous
drewdaemon 3864f63
[SO migrations] exit early if cluster routing allocation is disabled …
TinaHeiligers c4f8fc5
[shared-ux] CODEOWNERS update (#127169)
clintandrewhall 574a38f
[Security Solution] Fixes and unskips export rule test (#127060)
MadameSheema b5e1945
[CTI] Enable IM Rule Preview (#126651)
ecezalp 2fa485a
123580 o11 rules page (#124132)
mgiota 2bb237f
Add Playwright Service and New User Journeys for Performance tests (#…
suchcodemuchwow 7a00d24
[CORE] Allow find saved object to query on _id (#126933)
XavierM 79905ba
[DOCS] Add Stack Management cases (#126960)
lcawl 849542e
[Lens] data layer & reference layer as separate types (#126885)
mbondyra 0af4578
[ResponseOps] Add new plugin to collect additional kibana monitoring …
e3e5df6
[Security Solution][Lists] - Disable upload value lists if user is ki…
yctercero daace92
[kbn/pm] add timings for more parts of bootstrap (#127157)
0410d1f
Update dependency chromedriver to v99 (#127079)
renovate[bot] 6f5cd00
[App Search] Move to tabbed single tabbed JSON flyout with upload and…
scottybollinger 68ed188
[Security Solution] Adds CCS privileges warning enable switch in adva…
dplumlee bb1834d
[DOCS] Adds note for data source performance impact (#127184)
KOTungseth 1cb82f5
skip failing test suite (#126949)
kibanamachine 8c075c5
Increase timeout for Jest integration tests (#127220)
81eec7c
Made fix to broken test. Deleted all existing pipelines before test s…
cuff-links 7923667
[build] Up compression quality (#127064)
jbudz ad0eb60
[kbn/generate] add basic package generator (#127095)
f89d531
skip flaky suite (#123372)
mistic b9b4dc0
Remove deprecated & unused `SavedObjectsImportFailure.title` (#127043)
afharo 22369fd
Remove deprecated & unused `public-AsyncPlugin` (#127048)
afharo b76370d
Bump dependencies (#127238)
jportner 133e57f
[Lens] Show underlying data editor navigation (#125983)
dej611 565454c
Remove deprecated & unused `HttpServiceSetup.auth` (#127056)
afharo d1f0d23
remove opacity for fitting line series (#127176)
flash1293 eb4cd4a
Remove deprecated & unused `ElasticsearchServiceStart.legacy` (#127050)
afharo 06e453e
add updatedAt to SimpleSavedObject (#126359)
orouz 030816d
[Reporting] Capture Kibana stopped error (#127017)
jloleysens f74c894
Extend yarn es: plugin support + adding secure files to es keystore (…
Mpdreamz f5556f1
[Lens] Fix multi terms fields validation (#126618)
dej611 2836018
[Gauge] Custom color support (#126882)
Kuznietsov 9f880f2
[Lens] Switch to unified metric renderer (#126019)
VladLasitsa 6bcce44
[Flaky tests] Metric's server collector's integration tests (#127139)
afharo 299b21b
[Unified observability] Migrate deprecated IndexPattern types (#124962)
b32f1da
[Cloud Posture] Update resource type field query #127256
JordanSh b20a364
[Cases] Remove temporal public methods from the cases plugin (#127248)
academo 8dcf1ad
[TSVB2Lens] Supports static values (#126903)
stratoula c149966
Add instructions for connecting to local ES cluster started with `yar…
sorenlouv 671960f
[Cloud Posture] Add rules page (#126990)
orouz 1568eed
[Fleet] Fix empty assets on package install (#127070)
nchaulet 12f9e3c
[APM] Load list of services from ML/terms enum (#126581)
dgieselaar e930db1
[Cases] Fix persistent title error in EditableTitle (#127254)
academo 2e6d6c8
add new cluster id (#127265)
suchcodemuchwow b2d649f
Updates advanced settings `kibana.json` team ownership (#127186)
TinaHeiligers b1d6f87
[APM] Invalidate keys created by other when user has privileges (#12…
MiriamAparicio 46a739e
[Lens] Fix type check failure (#127277)
stratoula e932d83
[Archive Migration] dashboard/current/kibana (#126293)
b7f3271
[Lens] Improve Datatable content height with custom row height (#127134)
dej611 5217b9a
skip failing test (#127076)
d2c9a62
Enable local mtls (#127116)
lucasfcosta 488d939
[ci] Remove package testing jenkins source (#127300)
jbudz abc734f
[APM] Fix tooltip focus on service map (#127138)
MiriamAparicio ee369db
ci: discard configuration step and parallelism for performance test p…
suchcodemuchwow 6280ca1
[Security Solution][Endpoint] Create endpoint action and responses fr…
ashokaditya f169fe7
[Fleet] Use docker registry in fleet cloud preconfiguration test (#12…
nchaulet 5e8d66e
Remove logs.tar.gz (#127299)
jbudz e009115
[Fleet] Fix ES error during filtering on agent status (#127234)
jen-huang aa82d75
[Fleet] Remove dependency on `fieldFormatters` to fix Last activity a…
jen-huang ab109db
[package testing] Update networking profile to account for virtualbox…
jbudz 0ba204b
[Workplace Search] Connect button now displays correct copy (#127291)
sphilipse 0bc7a2e
[DOCS] Adds missing `monitoring.cluster_alerts.email_notifications.em…
KOTungseth e086d64
[ML] Space aware trained models (#123487)
jgowdyelastic 67e52e7
[ResponseOps] Exclude RBAC from SIEM for alerts search strategy (#126…
ca447c6
[Security Solution] Adds posix eventing model fields to generator scr…
kqualters-elastic b2cd94d
[Controls] Improve controls empty state (#125728)
Heenawter 2da341c
Unskip CTI tests (#127313)
nkhristinin 8782ced
[SharedUX] Migrate PageTemplate > NoDataPage > NoDataCard (#127025)
6456d18
Cancel search queries on timeout regardless of rule type (#124374)
mikecote 2bc710e
Merge branch 'main' of github.com:elastic/kibana into show-underlying…
drewdaemon f3a5b41
lazy-load view-underlying-data args
drewdaemon 868f0e8
only initialize datasource state the first time
drewdaemon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move all this logic outside of the embeddable? I think this has to be evaluated only on context menu update, rather than every change in the embeddable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I quite understand. Do you mean move it to a standalone function?
I think it initially needs to be evaluated when both
activeData
andexternalSearchContext
change because they don't necessarily resolve serially.The function only works when both are present, but we don't know which one will resolve first, so it is called in both places and the second time it's called we know that both
activeData
andexternalSearchContext
will be available.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO it makes sense to keep it inside of the embeddable, but only call it if requested from the action (see other comment)