Fix ruby 2.7 warning

[whois-marvin-42]

Fixed warning raised by latest ruby (FILE in eval) in base.rb

Fixes #221.

[AlexWayfer]

Ruby 2.7 is released, these warnings are annoying.

[deivid-rodriguez]

Right, I'll try to get a new version out today 👍.

[AlexWayfer]

Probably, we can take out common code with condition… into private method, for example. Or public class method, if it between different classes. Right now there is a duplication of logic.

[whois-marvin-42]

CI showed problems for Ruby < 2.6 (missing source_location) ... rolled back to working proposal.

[AlexWayfer]

CI showed problems for Ruby < 2.6 (missing source_location) ... rolled back to working proposal.

Oh, it's Binding#source_location, introduced in Ruby 2.6, and I saw Method#source_location… sorry, my bad.

[whois-marvin-42]

My bad too, I should have double-checked before making modifications.

[whois-marvin-42]

Don't know what deivid-rodriguez had in mind ... just hoping it helps. AlexWayfer, thanks for your point of view.

[AlexWayfer]

Don't know what deivid-rodriguez had in mind ... just hoping it helps. AlexWayfer, thanks for your point of view.

Everything is OK when CI passes. 👌

I just try to improve any code.

Thank you for contribution anyway.

[deivid-rodriguez]

It's looking good to me. Could you rebase and add a changelog entry?

[AlexWayfer]

and add a changelog entry?

It'd be nice to add a note about this in CONTRIBUTING.md.

[whois-marvin-42]

Done. Hope it's what you were expecting. Thanks for this tool btw.

[deivid-rodriguez]

Thanks so much @whois-marvin-42!

[deivid-rodriguez]

It'd be nice to add a note about this in CONTRIBUTING.md.

Sure @AlexWayfer, can you open a PR?

[AlexWayfer]

It'd be nice to add a note about this in CONTRIBUTING.md.

Sure @AlexWayfer, can you open a PR?

Maybe, but it's your requirement, maybe you have others, so, I think, it's better to do you, as Owner (maintainer). For example, I prefer to update Changelog before releases.

[deivid-rodriguez]

Sure, I'll do it myself.

[deivid-rodriguez]

When I said, "I'll try to get a new version out today", that was way too optimistic 😅. I'll do it during next week though.

[MarcusRiemer]

Any chance for a version bump?

[deivid-rodriguez]

I'll be releasing 3.8.0 in a bit. One question though, is this warning 2.7.0 specific? Because I can't reproduce it on MRI 2.6.

[AlexWayfer]

One question though, is this warning 2.7.0 specific?

Yep.

But, probably, in 2.6 too, with warnings flag: #221

From here: https://bugs.ruby-lang.org/issues/4352#note-23

The warning is printed only on the verbose mode in 2.6. It would be good to enable the warning by default in 2.7.

[deivid-rodriguez]

Thanks! I'll clarify this in the changelog!

[tisba]

I'm not sure why, but I see this warning, when I updated to Ruby 2.7.1 using pry-byebug 3.9.0:

gems/pry-byebug-3.9.0/lib/pry-byebug/pry_ext.rb:13: warning: __FILE__ in eval may not return location in binding; use Binding#source_location instead

[deivid-rodriguez]

I'm not sure why. Can you show the full backtrace?

[tisba]

Sure. What's the simplest way to get the full backtrace for warnings? 🤔

[tisba]

Ah, I missed the next line. Looks like it caused by pry-stack_explorer gem:

/home/smith/vendor/bundle/ruby/2.7.0/gems/pry-byebug-3.9.0/lib/pry-byebug/pry_ext.rb:13: warning: __FILE__ in eval may not return location in binding; use Binding#source_location instead
/home/smith/vendor/bundle/ruby/2.7.0/gems/pry-stack_explorer-0.4.9.3/lib/pry-stack_explorer/when_started_hook.rb:63: warning: in `eval'

Do I read this correctly?

[deivid-rodriguez]

Yeah, pry-stack_explorer needs to be updated. Specifically this line: https://github.com/pry/pry-stack_explorer/blob/02d18dceb7178ebbdc52673532afb85c1f8b51d8/lib/pry-stack_explorer/when_started_hook.rb#L63.

[tisba]

duh, I believe there is already an issue for this pry/pry-stack_explorer#43

Sorry for the noise here :)

[deivid-rodriguez]

No problem!