Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add pry-remote support for finish and continue #13

Closed
MaxGabriel opened this issue Dec 7, 2013 · 5 comments
Closed

Comments

@MaxGabriel
Copy link

Based on Mon-Ouie's comment, the current implementation of finish and continue is incompatible with pry-byebug/pry-debugger since it ends the current pry session.

I see there are several places where in pry-byebug's codebase that attempt to keep compatibility with pry-remote. Is it possible to also support the continue and finish commands?

@caius
Copy link

caius commented Jul 2, 2014

I'm also finding it odd that pry-byebug is exiting the pry instance when I invoke continue instead of dropping me back to the pry prompt and leaving the debugger instance as it were.

deivid-rodriguez pushed a commit that referenced this issue Aug 7, 2014
This should improve `pry-remote` support (see #13)
@deivid-rodriguez
Copy link
Owner

Hi @MaxGabriel and @calus!

Can you check latest master and see if this is fixed? Thanks!

@caius
Copy link

caius commented Aug 7, 2014

Hey @deivid-rodriguez

I tried to check master, but I'm getting an error trying to set a breakpoint now. I've raised that as a new issue - #32.

@caius
Copy link

caius commented Aug 7, 2014

Cheers for fixing #32 - tried it again now and it doesn't exit when I call continue anymore! That's awesome.

@deivid-rodriguez
Copy link
Owner

You are welcome! :)

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants