added reactive design doc #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiaxiao Zhou <[email protected]>
danbugs
requested changes
Jun 29, 2022
| @@ -4,8 +4,8 @@ wasi-cloud is a set of consistent, modular and portable interfaces that provide | |||
| 1. **Portability**: wasi-cloud is vendor-neutral, and can run on various host environments (e.g., cloud, edge, bare-metal etc.) and deployment runtime (e.g., VM, containers, standalone etc.), using different programming languages (e.g., Rust, C etc.) | |||
| 2. **Security**: applications that link to wasi-cloud libc will run in a sandboxed environment. The host will put capability functions in a sandboxed environment that the code can run. | |||
| 3. **Modular**: | |||
|
|
|||
|  | |||
| w | |||
|
|
||
| let events = exec::Events::get()?; | ||
| events | ||
| .listen(watch(rd, "my-key1")?))? |
There was a problem hiding this comment.
I think spacing might have gotten incorrectly formatted here.
| } | ||
| ``` | ||
|
|
||
| The above example shows that the guest application can define a events resource and listen on streams of events that are observed by invoking `watch` functions on resource descriptors and keys to watch on. |
There was a problem hiding this comment.
nit: instead of "a events", say "an events"
Comment on lines
+143
to
+145
| I then gave up using `wit_bindgen_wasmtime::export!("exec.wit");` in the host. | ||
|
|
||
| In [the second iteration](https://github.com/Mossaka/wasi-callback/pull/1/files#diff-42cb6807ad74b3e201c5a7ca98b911c5fa08380e942be6e4ac5807f8377f87fc), I copied the generated `[bindings.rs](http://bindings.rs)` to the src folder, and modified the generated APIs in this file to suit my needs. Specifically, I made the API to use reference counting to access host states, and thus I can have two mutable references to the same data structure. |
There was a problem hiding this comment.
question: again again again again, do we want to use first person here?
|
|
||
| ### Threading | ||
|
|
||
| In the reactive design, I want events to expose an API to resources so that each resource can implement their own listen for change code, and send event back to a channel. |
There was a problem hiding this comment.
question: again again again again again, do we want to use first-person here?
danbugs
force-pushed
the
main
branch
4 times, most recently
from
09239e3 to
0921137
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jiaxiao Zhou [email protected]