Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make tests fail-stop #59

Merged
merged 6 commits into from
Jul 5, 2022
Merged

make tests fail-stop #59

merged 6 commits into from
Jul 5, 2022

Conversation

Mossaka
Copy link
Member

@Mossaka Mossaka commented Jun 29, 2022

Due to #57 , I changed all the ? to unwrap() to make the test fail-stop.

Signed-off-by: Jiaxiao Zhou [email protected]

@Mossaka Mossaka changed the title modified integration tests to fail-stop and added az blob storage tests make tests fail-stop Jun 29, 2022
@Mossaka Mossaka added this to the July Milestone milestone Jun 29, 2022
@Mossaka Mossaka linked an issue Jun 29, 2022 that may be closed by this pull request
add integration tests for all capabilities in GH Actions #37
Open
3 tasks
Mossaka added 3 commits June 29, 2022 01:16
@Mossaka
added env vars
3a0b282 
Signed-off-by: Jiaxiao Zhou <[email protected]>
@Mossaka
changed how to call the main function
e14913e 
Signed-off-by: Jiaxiao Zhou <[email protected]>
@Mossaka
add Ctx type alias
ff54dee 
Signed-off-by: Jiaxiao Zhou <[email protected]>
@Mossaka Mossaka linked an issue Jun 29, 2022 that may be closed by this pull request
Propagate errors from guest to host #57
Closed
@Mossaka Mossaka requested a review from danbugs June 29, 2022 22:56
danbugs
danbugs reviewed Jun 29, 2022
View reviewed changes
Copy link
Collaborator

@danbugs danbugs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~a couple of comments/suggestions. This is mostly LGTM!

tests/integration_test.rs Outdated Show resolved Hide resolved
tests/integration_test.rs Outdated Show resolved Hide resolved
@Mossaka Mossaka removed a link to an issue Jun 29, 2022
add integration tests for all capabilities in GH Actions #37
Open
3 tasks
@Mossaka
removed test_kv_azureblob
2ece330 
Signed-off-by: Jiaxiao Zhou <[email protected]>
@danbugs danbugs force-pushed the main branch 3 times, most recently from 8091917 to 608c1eb Compare July 4, 2022 16:51
@danbugs danbugs mentioned this pull request Jul 4, 2022
Closed
@danbugs
Copy link
Collaborator

danbugs commented Jul 4, 2022

P.S. closes #57

@danbugs danbugs added the 🧪 tests Adding test coverage label Jul 4, 2022
@Mossaka
resolved a conflict
18af254 
Signed-off-by: Jiaxiao Zhou <[email protected]>
danbugs
danbugs approved these changes Jul 5, 2022
View reviewed changes
Copy link
Collaborator

@danbugs danbugs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mossaka Mossaka merged commit 921c58a into main Jul 5, 2022
@Mossaka Mossaka deleted the jiazho/tests/improve_1 branch July 5, 2022 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbugs danbugs danbugs approved these changes

Assignees
No one assigned
Labels
🧪 tests Adding test coverage
Projects
None yet
Milestone
July Milestone
Development

Successfully merging this pull request may close these issues.

Propagate errors from guest to host
2 participants
@Mossaka @danbugs