This repository has been archived by the owner on Feb 11, 2025. It is now read-only.
feat: push docker image #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankYang0529
requested review from
thomastaylor312,
technosophos and
radu-matei
as code owners
|
@microsoft-github-policy-service agree [company="default"] |
|
@microsoft-github-policy-service agree |
FrankYang0529
force-pushed
the
add-release-docker-image
branch
from
cd3ca71 to
136818f
Compare
vdice
reviewed
Oct 26, 2022
There was a problem hiding this comment.
Defer to the code owners for final decision, but I'm wondering if we want to push to this repo's GitHub container registry instead (ghcr.io/deislabs/bindle)? We should be able to use the default $GITHUB_TOKEN to push images.
Signed-off-by: Frank Yang <[email protected]>
FrankYang0529
force-pushed
the
add-release-docker-image
branch
from
136818f to
91d119e
Compare
Yeah, I think it's good to use the default |
vdice
approved these changes
Oct 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: fermyon/installer#63, fermyon/installer#100 (comment)