fix(postgres) block invalid S3 bucket name #181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it. |
|
@bacongobbler and @paulczar are potential reviewers of this pull request based on my analysis of |
|
... oops, the commit name should have been something like "fix(postgres): block invalid S3 bucket name" according to http://docs.deis.io/en/latest/contributing/standards/#commit-style-guide |
greglearns
changed the title
Using a period in an S3 BUCKET_NAME causes `helm install -f values.yaml deis/workflow --namespace=deis` to fail. REPRODUCING THE BUG Using a period in BUCKET_NAME causes `helm install -f values.yaml deis/workflow --namespace=deis` to fail with this error: ``` ssl.CertificateError: hostname 'deis.subdomain.domain.com-registry.s3-us-west-2.amazonaws.com' doesn't match either of 's3-us-west-2.amazonaws.com', '*.s3-us-west-2.amazonaws.com', 's3.us-west-2.amazonaws.com', '*.s3.us-west-2.amazonaws.com', 's3.dualstack.us-west-2.amazonaws.com', '*.s3.dualstack.us-west-2.amazonaws.com', '*.s3.amazonaws.com' 2017/01/14 07:20:04 Error creating the registry bucket: exit status 1 ``` A POSSIBLE FIX Not sure how to create a test for this (I just started using Deis 4 days ago), but, a hacky test is this: ``` echo "a.bad.thing-mixed-with-a-good-thing" | sed "s/[.]/-/g" ``` RELATED ISSUES deis/workflow#700 deis/workflow#701 (documentation fix) Note: this bug also exists for https://github.com/deis/registry/blob/master/rootfs/bin/create-bucket#L27
|
Closing: will resubmit with git commit message fixes. |
|
New PR: #182 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a period in BUCKET_NAME causes
helm install -f values.yaml deis/workflow --namespace=deisto failRELATED ISSUES
deis/workflow#700
deis/workflow#701 (documentation fix)
Note: this bug also exists for https://github.com/deis/registry/blob/master/rootfs/bin/create-bucket#L27
REPRODUCING THE BUG
Using a period in BUCKET_NAME causes
helm install -f values.yaml deis/workflow --namespace=deisto fail with this error:A POSSIBLE FIX
Not sure how to create a test for this (I just started using Deis 4 days ago), but, a hacky test is this: