Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

Commit

Permalink
fix(charts) add quote around daemon_environment value
Browse files Browse the repository at this point in the history
This change need to to avoid validation error when run helm install.
Type of spec.template.spec.containers[].env[].value field must be
string.

how to test this change (it also reproduce problem)

```
$ cat<<EOS > values.yaml
daemon_environment:
  SEND_LOGS_TO_NSQ: "true"
EOS

$ helm install --namespace deis-fluentd ./charts/fluentd -f values.yaml
```

Before this change, we got following error.

> Error: error validating "": error validating data: expected type string,
for field spec.template.spec.containers[0].env[0].value, got bool
  • Loading branch information
hakobera committed Apr 12, 2017
1 parent 9caba5d commit a9674a3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion charts/fluentd/templates/logger-fluentd-daemon.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ spec:
{{- end}}
{{- range $key, $value := .Values.daemon_environment }}
- name: {{ $key }}
value: {{ $value }}
value: {{ $value | quote }}
{{- end }}
volumeMounts:
- name: varlog
Expand Down

0 comments on commit a9674a3

Please sign in to comment.