Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] A bug hide in here. #9

Closed
op06072 opened this issue Apr 12, 2023 · 1 comment
Closed

[Issue] A bug hide in here. #9

op06072 opened this issue Apr 12, 2023 · 1 comment
Assignees
@dehydratedpotato
Labels
bug Something isn't working

Comments

@op06072
Copy link

op06072 commented Apr 12, 2023 •
edited
Loading

Describe the bug
0 division bug can occur

Project Version (please complete the following information):

  • Version v0.4

Operating System (please complete the following information):

  • Name: Ventura (but this doesn't matter)
  • Version 13.3

Device (please complete the following information):

  • Model: 2021 MBP 16 (this also doesn't matter)
  • CPU: Apple M1 Pro

Additional context
https://github.com/BitesPotatoBacks/SocPowerBuddy/blob/b899acef74cdb87a7d36f6a9df95063cc72b6315/SocPowerBuddy/sampler.m#L279
In sampler.m line 279, [vd->core_use[i][iii] floatValue] / ([vd->core_sums[i][iii] floatValue] + [vd->core_use[i][iii] floatValue]).
This can occur 0 division bug. But this bug hide in 0% usage. I find this bug when I closed my macbook display while running my neoasitop.
@op06072 op06072 added the bug Something isn't working label Apr 12, 2023
@op06072 op06072 changed the title [Issue] A bug is hide in here. [Issue] A bug hide in here. Apr 12, 2023
@dehydratedpotato
Copy link
Owner

@op06072 i Currently don’t have access to my Apple Silicon machine but I will fix this when I patch #8 👍

dehydratedpotato added a commit that referenced this issue May 31, 2023
@dehydratedpotato
Fix #8 and #9, refactoring
2bd9613
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dehydratedpotato dehydratedpotato

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@op06072 @dehydratedpotato