fix

defstudio · Apr 19, 2024 · 5469b54 · 5469b54
1 parent 8d51331
commit 5469b54
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/README.md b/README.md
@@ -41,9 +41,7 @@ enum AppFeature
     /* Feature resolution */
 
     //with a single method:
-    protected function resolve(?Authenticatable $user = null) {
-        $user ??= auth()->user();
-
+    protected function resolve(Authenticatable $user = null) {
         match($this){
             case self::multi_language => true,
             case self::impersonate => $user->isAdmin(),
@@ -53,9 +51,7 @@ enum AppFeature
 
     //or with a dedicated method:
 
-    protected function resolveImpersonate(?Authenticatable $user = null){
-        $user ??= auth()->user();
-
+    protected function resolveImpersonate(Authenticatable $user = null){
         return $user->isSuperAdmin();
     }
 }

diff --git a/src/Concerns/DefinesFeatures.php b/src/Concerns/DefinesFeatures.php
@@ -57,7 +57,7 @@ public function purge(): void
         Pennant::purge($this->featureName());
     }
 
-    protected function resolve(?Authenticatable $scope = null): bool
+    protected function resolve(Authenticatable $scope = null): bool
     {
         $featureName = $this->featureName();
         $camelFeatureName = str($this->featureName())->camel()->ucfirst();