chore: v1.0.0 deployment addresses #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xteddybear
reviewed
Jul 25, 2024
README.md
Outdated
|
|
||
| Gnosis Mainnet: | ||
| - BCoWFactory: (0xaD0447be7BDC80cf2e6DA20B13599E5dc859b667)[https://etherscan.io/address/0xaD0447be7BDC80cf2e6DA20B13599E5dc859b667] |
There was a problem hiding this comment.
address is for a BCoWFactory in gnosis chain but link is on etherscan (where there's a previously deployed BFactory)
README.md
Outdated
| @@ -60,8 +60,14 @@ yarn test # run the tests | |||
|
|
|||
| # Deployments | |||
| Ethereum Mainnet: | |||
| - BCoWFactory: (0x21Cd97D70f8475DF3d62917880aF9f41D9a9dCeF)[https://etherscan.io/address/0x21Cd97D70f8475DF3d62917880aF9f41D9a9dCeF#code] | |||
| - BCoWFactory: (0x5AC134DAC7070eFeE8b1C5e3fD0B353922ceD843)[https://etherscan.io/address/0x5AC134DAC7070eFeE8b1C5e3fD0B353922ceD843] | |||
There was a problem hiding this comment.
markdown links are backwards: it should be [display text](destination ur)
package.json
Outdated
| "deploy:bcowfactory:mainnet": "forge script DeployBCoWFactory -vvvvv --rpc-url $MAINNET_RPC --broadcast --chain mainnet --private-key $MAINNET_DEPLOYER_PK --verify", | ||
| "deploy:bcowfactory:testnet": "forge script DeployBCoWFactory -vvvvv --rpc-url $SEPOLIA_RPC --broadcast --chain sepolia --private-key $SEPOLIA_DEPLOYER_PK --verify", | ||
| "deploy:bfactory:gnosis": "forge script DeployBFactory -vvvvv --rpc-url $GNOSIS --broadcast --chain gnosis --private-key $GNOSIS_DEPLOYER_PK --verify", |
script/Registry.s.sol
Outdated
| bCoWFactory = BCoWFactory(0xe8587525430fFC9193831e1113a672f3133C1B8A); | ||
| bCoWHelper = BCoWHelper(0x0fd365F9Ed185512536E7dbfc7a8DaE43cD3CA09); | ||
| bCoWFactory = BCoWFactory(0xf3916A8567DdC51a60208B35AC542F5226f46773); | ||
| bCoWHelper = BCoWHelper(0x55DDf396886C85e443E0B5A8E42CAA3939E4Cf50); | ||
| } else { | ||
| // TODO: add Gnosis chain |
| @@ -20,14 +17,16 @@ abstract contract Registry is Params { | |||
| // TODO: redeploy | |||
| if (chainId == 1) { | |||
| // Ethereum Mainnet | |||
| bFactory = BFactory(0xaD0447be7BDC80cf2e6DA20B13599E5dc859b667); | |||
There was a problem hiding this comment.
are we assuming BaseScript won't use the regular factory?
0xteddybear
reviewed
Jul 25, 2024
package.json
Outdated
| @@ -16,15 +16,18 @@ | |||
| "build": "forge build", | |||
| "build:optimized": "FOUNDRY_PROFILE=optimized forge build", | |||
| "coverage": "forge coverage --match-path 'test/unit/**'", | |||
| "deploy:bcowfactory:gnosis": "forge script DeployBCoWFactory -vvvvv --rpc-url $GNOSIS --broadcast --chain gnosis --private-key $GNOSIS_DEPLOYER_PK --verify", | |||
0xteddybear
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deployed c250754 to mainnet, gnosis and sepolia.