feat: increasing max swap fee to 99.9999% #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
wei3erHase
changed the title
0xteddybear
reviewed
Jul 16, 2024
| @@ -17,7 +17,7 @@ contract BConst { | |||
| /// @notice The minimum swap fee that can be set. | |||
| uint256 public constant MIN_FEE = BONE / 10 ** 6; | |||
| /// @notice The maximum swap fee that can be set. | |||
| uint256 public constant MAX_FEE = BONE / 10; | |||
| uint256 public constant MAX_FEE = BONE - MIN_FEE; | |||
There was a problem hiding this comment.
why set it to BONE - MIN_FEE instead of just BONE? It doesn't seem to trigger any errors, which tells me that either
- it's perfectly lawful
- we're not testing for high fee values because of other pre-existing
vm.assumeorbound
I'm currently trying to make sure it's not the latter
There was a problem hiding this comment.
i think it was chosen in order to avoid edge cases, which now that i'm looking at the BMath tree it reverts in every swap operation (because of the calcSpotPrice division by zero), but it doesn't revert in joinswap or exitswap, causing an unconsistent behaviour
because of this, i believe is better to provide a highly taxed normal behaviour than fall into unchecked reverting cases, i think now is better 99.9999% instead of allowing 100%
wei3erHase
changed the title
wei3erHase
force-pushed
the
feat/max-swap-fee
branch
from
9c90725 to
755dbc0
Compare
wei3erHase
changed the title
wei3erHase
commented
Jul 16, 2024
0xteddybear
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by request of CoW team, this change is intended to allow the pool owner from desincentivizing direct swaps on the pool (via BPool methods)