fix: login to registry1 for publishing #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikevanhemert
changed the title
mjnagel
requested changes
Dec 18, 2023
There was a problem hiding this comment.
This change LGTM but to save you one more PR you will want to add tasks/publish.yaml to https://github.com/defenseunicorns/uds-package-gitlab/blob/registry1-login/release-please-config.json#L13 and make sure its current version is in sync with the current -1 version on release please.
|
And based on CI looks like one more spot for release-please to update 😄 - https://github.com/defenseunicorns/uds-package-gitlab/blob/registry1-login/bundle/uds-bundle.yaml#L22 |
mjnagel
reviewed
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.