Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: allow configurability of SSH and harden application settings #196

Merged
merged 22 commits into from
Sep 24, 2024

Conversation

Racer159
Copy link
Contributor

@Racer159 Racer159 commented Sep 11, 2024

Description

This PR disables SSH more fully by default but adds an option to reconfigure it later - it also adds a way to harden specific settings in GitLab declaratively.

Important

⚠️ BREAKING CHANGE - this is a breaking change as it will force hardened settings on the end user unless the settingsJob is disabled or reconfigured.

Related Issue

Fixes #189
Fixes #190

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@Racer159 Racer159 requested a review from a team as a code owner September 11, 2024 16:45
@Racer159 Racer159 changed the title feat: allow configurability of SSH and application settings feat!: allow configurability of SSH and application settings Sep 11, 2024
@Racer159 Racer159 self-assigned this Sep 16, 2024
@Racer159 Racer159 changed the title feat!: allow configurability of SSH and application settings feat!: allow configurability of SSH and harden application settings Sep 17, 2024
mjnagel added a commit to defenseunicorns/uds-core that referenced this pull request Sep 18, 2024
## Description

This adds a variable to override service ports in the uds-core test
bundles (useful for adding additional ports to expose)

## Related Issue

Relates to
defenseunicorns/uds-package-gitlab#196

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [X] Test, docs, adr added or updated as needed
- [X] [Contributor
Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)
followed

---------

Co-authored-by: Micah Nagel <[email protected]>
@Racer159
Copy link
Contributor Author

screenshot of password length applying
image

@Racer159 Racer159 merged commit bcd34c6 into main Sep 24, 2024
12 checks passed
Racer159 pushed a commit that referenced this pull request Sep 24, 2024
🤖 I have created a release *beep* *boop*
---


##
[17.2.7-uds.1](v17.2.7-uds.0...v17.2.7-uds.1)
(2024-09-24)


### ⚠ BREAKING CHANGES

* allow configurability of SSH and harden application settings
([#196](#196))

### Features

* allow configurability of SSH and harden application settings
([#196](#196))
([bcd34c6](bcd34c6))


### Miscellaneous

* **deps:** update gitlab support dependencies
([#191](#191))
([3e90272](3e90272))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate GitLab against its hardening recommendations Disable SSH by default - provide a config to expose
2 participants