Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add wait for GL package CR readiness #144

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

Racer159
Copy link
Contributor

@Racer159 Racer159 commented Jun 5, 2024

Description

Adds a wait action for the GL package CR. This is consistent with the pattern in uds-core however it runs after the GitLab chart installs (meaning the GitLab chart may still fail waiting on resources like secrets to exist) however this will catch other issues such as failed updates to resources or missing resources the chart doesn't directly depend on like netpols.

Related Issue

Fixes #140

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@Racer159 Racer159 modified the milestone: Release Jun 5, 2024
Copy link
Contributor

@zachariahmiller zachariahmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Racer159 Racer159 merged commit eaa59dd into main Jun 5, 2024
16 of 20 checks passed
Racer159 pushed a commit that referenced this pull request Jun 20, 2024
🤖 I have created a release *beep* *boop*
---


##
[17.0.2-uds.0](v17.0.1-uds.1...v17.0.2-uds.0)
(2024-06-20)


### Features

* add wait for GL package CR readiness
([#144](#144))
([eaa59dd](eaa59dd))
* allow for Postgres password secret generation
([#147](#147))
([5d48380](5d48380))


### Bug Fixes

* add missing exporter netpols
([#142](#142))
([9b5a258](9b5a258))


### Miscellaneous

* cache playwright and add tests to amd64 release
([#155](#155))
([4af9d3a](4af9d3a))
* **deps:** update gitlab package dependencies
([#154](#154))
([e5a8f66](e5a8f66))
* **deps:** update gitlab support dependencies
([#137](#137))
([66bb3ba](66bb3ba))
* document how to use the database
([#149](#149))
([3ec9044](3ec9044))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy does not wait on Package CR readiness
2 participants