Deploy does not wait on Package CR readiness
#140
Labels
possible-bug 🐛
Something may not be working
Comments
5 tasks
Racer159
added a commit
that referenced
this issue
Jun 5, 2024
## Description Adds a wait action for the GL package CR. This is consistent with the pattern in uds-core however it runs _after_ the GitLab chart installs (meaning the GitLab chart may still fail waiting on resources like secrets to exist) however this will catch other issues such as failed updates to resources or missing resources the chart doesn't directly depend on like netpols. ## Related Issue Fixes #140 ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [X] Test, docs, adr added or updated as needed - [X] [Contributor Guide Steps](https://github.com/defenseunicorns/uds-package-gitlab/blob/main/CONTRIBUTING.md#developer-workflow) followed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment
N/A - not environment specific, but encountered on RKE2.
Steps to reproduce
Packageconfiguration (example: add an erroneous client scope)Expected result
Deployment should fail if
PackageCR is not ready.Actual Result
Since helm/zarf do not wait on the
Package, and there is no action in the zarf.yaml to wait on it, it's status is ignored for the deployment.Severity/Priority
Low/Medium
Additional Context
In uds-core we added onDeploy.after actions to most packages to validate they are fully healthy before proceeding, example - https://github.com/defenseunicorns/uds-core/blob/main/src/grafana/common/zarf.yaml#L21-L31. Unsure, but expect this is an issue on other SWF repos as well.
The text was updated successfully, but these errors were encountered: