Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: update the license to AGPLv3 or Commercial #286

Merged
merged 15 commits into from
Oct 10, 2024
Merged

chore!: update the license to AGPLv3 or Commercial #286

merged 15 commits into from
Oct 10, 2024

Conversation

Racer159
Copy link
Contributor

@Racer159 Racer159 commented Oct 9, 2024 •
edited
Loading

Description

This updates the license of this repo and adds an ADR to supersede the last one.

⚠️ BREAKING CHANGE - once this is merged any repos using the lint workflow will break until they run uds run lint:fix-license to add the AGPL-3.0-or-later OR Commercial SPDX Identifier - this may also require some adjustment to things like Helm templates

Checklist before merging

  • ADR proposed if making an architectural change to the repo
  • Tests run, docs added or updated as needed

@Racer159 Racer159 requested review from jeff-mccoy, daveworth and a team as code owners October 9, 2024 18:55
@Racer159 Racer159 force-pushed the update-license branch 2 times, most recently from 3237cca to 905ee6b Compare October 9, 2024 18:58
mjnagel
mjnagel previously approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@mjnagel mjnagel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ (approved pending CI lint fix)

docs/adrs/0004-agpl-v3-for-all-uds-products.md Outdated Show resolved Hide resolved
@Racer159
Copy link
Contributor Author

Racer159 commented Oct 9, 2024

First commit the linter fails successfully: https://github.com/defenseunicorns/uds-common/actions/runs/11261472517/job/31314991974?pr=286

@Racer159 Racer159 changed the title chore: update the license to AGPLv3 chore: update the license to AGPLv3+Commercial Oct 9, 2024
@Racer159 Racer159 changed the title chore: update the license to AGPLv3+Commercial chore: update the license to AGPLv3 or Commercial Oct 9, 2024
@Racer159 Racer159 changed the title chore: update the license to AGPLv3 or Commercial chore!: update the license to AGPLv3 or Commercial Oct 9, 2024
zachariahmiller
zachariahmiller previously approved these changes Oct 9, 2024
View reviewed changes
@zachariahmiller
Copy link
Contributor

this may also require some adjustment to things like Helm templates
😢

@eddiezane
Copy link
Member

I don't think Commercial is a valid spdx identifier. I think we need to do something like this

https://www.qt.io/blog/switching-to-spdx#:~:text=//%20SPDX%2DLicense%2DIdentifier%3A%20LicenseRef%2DQt%2DCommercial%20OR%20LGPL%2D3.0%2Donly%20OR%20GPL%2D2.0%2Donly%20OR%20GPL%2D3.0%2Donly

mjnagel
mjnagel previously approved these changes Oct 9, 2024
View reviewed changes
andrewg-xyz
andrewg-xyz previously approved these changes Oct 9, 2024
View reviewed changes
daveworth
daveworth previously approved these changes Oct 9, 2024
View reviewed changes
andrewg-xyz
andrewg-xyz previously approved these changes Oct 9, 2024
View reviewed changes
@Racer159 Racer159 dismissed stale reviews from andrewg-xyz and daveworth via 04938d3 October 10, 2024 21:56
@Racer159 Racer159 merged commit 2a9ca00 into main Oct 10, 2024
15 checks passed
@Racer159 Racer159 deleted the update-license branch October 10, 2024 22:38
@github-actions github-actions bot mentioned this pull request Oct 10, 2024
Merged
@jeff-mccoy jeff-mccoy mentioned this pull request Oct 15, 2024
Merged
5 tasks
This was referenced Dec 6, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-mccoy jeff-mccoy jeff-mccoy approved these changes

@mjnagel mjnagel mjnagel approved these changes

@daveworth daveworth daveworth left review comments

@andrewg-xyz andrewg-xyz andrewg-xyz left review comments

@zachariahmiller zachariahmiller zachariahmiller left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Racer159 @zachariahmiller @eddiezane @jeff-mccoy @daveworth @mjnagel @andrewg-xyz