-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/expose gitlab ssh #20
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
blancharda
commented
Dec 14, 2023
- Refactors DUBBD to use a skeleton build
- Incorporates certs as zarf/uds variables rather than reading in from files
- exposes port 22 on the ingress gateway
- adds netpols and a virtual service to allow SSH access to gitlab
…itlab ssh service
Co-authored-by: awendt <[email protected]>
Co-authored-by: awendt <[email protected]>
Co-authored-by: awendt <[email protected]>
anthonywendt
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
anthonywendt
pushed a commit
that referenced
this pull request
Dec 15, 2023
feat!: build a dubbd skeleton package with custom values and expose SSH for gitlab * Moving dubbd install to a skeleton build with custom values. A * adding gitlab ssh VS and netpols BREAKING: certificates are expected in the configuration now -- no defaults will be loaded BEGIN_COMMIT_OVERRIDE feat!: build dubbd skeleton package feat!: expose ssh for gitlab feat!: certs are expted in uds-config now END_COMMIT_OVERRIDE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.