Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle empty (null/object/string) fetch responses gracefully #61

Merged
merged 4 commits into from
Apr 26, 2023
Merged

handle empty (null/object/string) fetch responses gracefully #61

merged 4 commits into from
Apr 26, 2023

Conversation

jeff-mccoy
Copy link
Member

No description provided.

@jeff-mccoy jeff-mccoy requested a review from bdw617 as a code owner April 26, 2023 00:35
bdw617
bdw617 previously approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@bdw617 bdw617 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you forgot to handle xml, no... I'm kidding, it looks good.

@jeff-mccoy
Copy link
Member Author

Look at that 🥲 the tests work....had to make a couple tweaks due to an e2e test failure

@jeff-mccoy jeff-mccoy requested a review from bdw617 April 26, 2023 03:42
@jeff-mccoy jeff-mccoy merged commit 07c33ee into main Apr 26, 2023
@jeff-mccoy jeff-mccoy deleted the fetch-handle-empty-response branch April 26, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdw617 bdw617 bdw617 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeff-mccoy @bdw617