Fix k8s import/export #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: razzle <[email protected]>
Noxsios
requested review from
jeff-mccoy,
bdw617 and
rjferguson21
as code owners
Signed-off-by: razzle <[email protected]>
jeff-mccoy
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the k8s export so it can be used properly. Unsure how this affects the bundle as before the k8s re-export was not actually doing anything and now it is properly pulling in all of
@kubernetes/client-node.Pretty sure that this will increase the size of the JS by a bit because its now importing everything from the k8s client and not tree shaking imports.