Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove circular dependency with Assets class #1635

Merged
merged 14 commits into from
Jan 7, 2025
Merged

Conversation

samayer12
Copy link
Collaborator

Description

This PR addresses circular dependencies in the code.

Related Issue

Fixes #1633

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.40%. Comparing base (cfbcb59) to head (b9cbc4a).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1635   +/-   ##
=======================================
  Coverage   81.40%   81.40%           
=======================================
  Files          43       43           
  Lines        1979     1979           
  Branches      411      411           
=======================================
  Hits         1611     1611           
  Misses        366      366           
  Partials        2        2           
Files with missing lines Coverage Δ
src/cli/build.helpers.ts 68.67% <ø> (ø)
src/lib/assets/pods.ts 94.64% <ø> (ø)

src/lib/assets/assets.ts Outdated Show resolved Hide resolved
src/lib/assets/assets.ts Show resolved Hide resolved
src/lib/assets/assets.ts Outdated Show resolved Hide resolved
src/lib/assets/yaml.ts Outdated Show resolved Hide resolved
src/lib/assets/yaml.ts Outdated Show resolved Hide resolved
src/lib/assets/yaml.ts Outdated Show resolved Hide resolved
src/lib/assets/yaml.ts Outdated Show resolved Hide resolved
@samayer12 samayer12 marked this pull request as ready for review January 7, 2025 19:18
@samayer12 samayer12 requested a review from a team as a code owner January 7, 2025 19:18
@cmwylie19 cmwylie19 added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit 7c91f76 Jan 7, 2025
48 checks passed
@cmwylie19 cmwylie19 deleted the 1633-circular-deps branch January 7, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Remove circular dependency in lib/assets/index.ts > lib/assets/yaml.ts
2 participants