-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make load tests more resilient to slow metrics-server startup in GH CI #1634
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1634 +/- ##
=======================================
Coverage 81.40% 81.40%
=======================================
Files 43 43
Lines 1979 1979
Branches 438 439 +1
=======================================
Hits 1611 1611
+ Misses 366 340 -26
- Partials 2 28 +26 |
Seems like we're just trying to call for metrics before the metrics-server is fully ready..? https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kubectl/pkg/cmd/top/top_pod.go#L207 So... I'm thinking that adding a wait toward the end of the |
Yeah, nothin's bombin'-out anymore so I think I'm going to call this one good & send it for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Adds some add'l try/catches+output to allow us to see what's actually blowing up in CI.
Related Issue
Fixes #1622
Type of change
Checklist before merging