Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provides a way to override ignored namespaces at deployment time #1617

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

cmwylie19
Copy link
Collaborator

@cmwylie19 cmwylie19 commented Jan 3, 2025

Description

In scenarios where build-time configuration is not feasible, you can set the namespaces to ignore at deploy time by using the PEPR_IGNORED_NAMESPACES environment variable in your deployments. However, this method bypasses the build-time safety checks and is not recommended except as a last resort.

Needs: 1618

Related Issue

Fixes #1610

Relates to #1618

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@cmwylie19 cmwylie19 requested a review from a team as a code owner January 3, 2025 16:02
@cmwylie19 cmwylie19 added this to the v0.42.2 milestone Jan 3, 2025
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.98%. Comparing base (cd03899) to head (a9b1bfc).

Files with missing lines Patch % Lines
src/lib/assets/webhooks.ts 85.71% 1 Missing ⚠️
src/lib/core/module.ts 50.00% 1 Missing ⚠️
src/lib/processors/validate-processor.ts 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1617      +/-   ##
==========================================
- Coverage   81.24%   79.98%   -1.27%     
==========================================
  Files          42       43       +1     
  Lines        1962     2013      +51     
  Branches      432      419      -13     
==========================================
+ Hits         1594     1610      +16     
- Misses        340      401      +61     
+ Partials       28        2      -26     
Files with missing lines Coverage Δ
src/lib/processors/mutate-processor.ts 63.04% <100.00%> (+0.40%) ⬆️
src/lib/assets/webhooks.ts 27.08% <85.71%> (ø)
src/lib/core/module.ts 81.81% <50.00%> (+0.56%) ⬆️
src/lib/processors/validate-processor.ts 55.81% <50.00%> (+1.05%) ⬆️

... and 5 files with indirect coverage changes

@cmwylie19 cmwylie19 added the uds Tracked by UDS project. Adds to UDS Inbox when applied. label Jan 3, 2025
@cmwylie19 cmwylie19 marked this pull request as draft January 3, 2025 16:25
Signed-off-by: Case Wylie <[email protected]>
@cmwylie19 cmwylie19 marked this pull request as ready for review January 6, 2025 13:05
@cmwylie19 cmwylie19 marked this pull request as draft January 6, 2025 16:27
@cmwylie19 cmwylie19 added the ON-HOLD Needs investigation label Jan 6, 2025
@cmwylie19
Copy link
Collaborator Author

ON-HOLD label applied as we are going through some finalizing details with our downstream stakeholder. This implementation is likely to slightly change a bit after having chatted through some specifics on how they want to use it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ON-HOLD Needs investigation uds Tracked by UDS project. Adds to UDS Inbox when applied.
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

Allow deploy-time configurable alwaysIgnore.namespaces
1 participant