Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: organize core pepr files into lib/core/ #1594

Merged
merged 2 commits into from
Dec 17, 2024
Merged

chore: organize core pepr files into lib/core/ #1594

merged 2 commits into from
Dec 17, 2024

Conversation

samayer12
Copy link
Collaborator

Description

While reviewing how journey/ tests can be refactored, several files in lib/ seemed to represent core functionality about Pepr.

For clarity, we may want to move them to a shared folder. The impacted files are:

src/lib/capability.ts
src/lib/module.ts
src/lib/queue.ts
src/lib/storage.ts
src/lib/schedule.ts
src/lib/capability.test.ts
src/lib/module.test.ts
src/lib/queue.test.ts
src/lib/storage.test.ts
src/lib/schedule.test.ts

If we feel this represents core Pepr functionality and provides more clarity than leaving them in lib/ at the top-level, we should consider this PR.

End to End Test:
(See Pepr Excellent Examples)

Related Issue

None

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@samayer12 samayer12 requested a review from a team as a code owner December 17, 2024 17:26
@cmwylie19 cmwylie19 enabled auto-merge December 17, 2024 17:30
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.09%. Comparing base (73831e0) to head (86e37c3).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1594   +/-   ##
=======================================
  Coverage   81.09%   81.09%           
=======================================
  Files          41       41           
  Lines        1947     1947           
  Branches      431      404   -27     
=======================================
  Hits         1579     1579           
- Misses        340      366   +26     
+ Partials       28        2   -26     
Files with missing lines Coverage Δ
src/lib.ts 100.00% <100.00%> (ø)
src/lib/assets/pods.ts 94.64% <ø> (ø)
src/lib/controller/index.ts 10.40% <100.00%> (ø)
src/lib/controller/store.ts 12.00% <ø> (ø)
src/lib/controller/storeCache.ts 100.00% <ø> (ø)
src/lib/core/capability.ts 94.90% <100.00%> (ø)
src/lib/core/module.ts 81.25% <100.00%> (ø)
src/lib/core/queue.ts 100.00% <100.00%> (ø)
src/lib/core/schedule.ts 100.00% <ø> (ø)
src/lib/core/storage.ts 83.56% <ø> (ø)
... and 3 more

... and 1 file with indirect coverage changes

@cmwylie19 cmwylie19 added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit cc590bf Dec 17, 2024
48 checks passed
@cmwylie19 cmwylie19 deleted the create-core branch December 17, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants