Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: complexity shouldSkipRequest #1578

Merged
merged 2 commits into from
Dec 13, 2024
Merged

chore: complexity shouldSkipRequest #1578

merged 2 commits into from
Dec 13, 2024

Conversation

cmwylie19
Copy link
Collaborator

Description

Reduce the complexity of shouldSkipRequest

Related Issue

Fixes #1535

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@cmwylie19 cmwylie19 requested a review from a team as a code owner December 13, 2024 17:35
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.83%. Comparing base (34f4e50) to head (44c32fc).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1578      +/-   ##
==========================================
+ Coverage   80.22%   80.83%   +0.60%     
==========================================
  Files          42       42              
  Lines        1896     1951      +55     
  Branches      427      443      +16     
==========================================
+ Hits         1521     1577      +56     
+ Misses        346      345       -1     
  Partials       29       29              
Files with missing lines Coverage Δ
src/lib/filter/filter.ts 100.00% <100.00%> (+2.50%) ⬆️

Copy link
Collaborator

@samayer12 samayer12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR, this makes it easier to test each filter in isolation.

@samayer12 samayer12 added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit e4d24a6 Dec 13, 2024
48 checks passed
@samayer12 samayer12 deleted the 1535 branch December 13, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

complexity of filter.ts
2 participants