Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reduce complexity of helpers.ts #1575

Merged
merged 5 commits into from
Dec 13, 2024
Merged

Conversation

samayer12
Copy link
Collaborator

Description

This PR addresses complexity in helpers.ts

End to End Test:
(See Pepr Excellent Examples)

Related Issue

Fixes #1534

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@samayer12 samayer12 force-pushed the 1534-helper-complexity branch from b426f3f to 33bdbf4 Compare December 13, 2024 16:36
@samayer12 samayer12 marked this pull request as ready for review December 13, 2024 16:38
@samayer12 samayer12 requested a review from a team as a code owner December 13, 2024 16:38
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.22%. Comparing base (f618e2b) to head (33bdbf4).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1575      +/-   ##
==========================================
- Coverage   80.28%   80.22%   -0.07%     
==========================================
  Files          41       42       +1     
  Lines        1902     1896       -6     
  Branches      444      427      -17     
==========================================
- Hits         1527     1521       -6     
  Misses        346      346              
  Partials       29       29              
Files with missing lines Coverage Δ
src/lib/filter/filterNoMatchReason.ts 100.00% <100.00%> (ø)
src/lib/helpers.ts 97.24% <100.00%> (-0.69%) ⬇️
src/lib/watch-processor.ts 78.64% <100.00%> (ø)

@samayer12 samayer12 self-assigned this Dec 13, 2024
Copy link
Collaborator

@cmwylie19 cmwylie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@cmwylie19 cmwylie19 added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit 34f4e50 Dec 13, 2024
48 checks passed
@cmwylie19 cmwylie19 deleted the 1534-helper-complexity branch December 13, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

complexity of helpers.ts
2 participants