Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: return types on module, included-files, and helpers to standardize our typing #1574

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

cmwylie19
Copy link
Collaborator

Description

Return types on module, included-files, and helpers to standardize our typing

Related Issue

Fixes #1548

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Signed-off-by: Case Wylie <[email protected]>
@cmwylie19 cmwylie19 requested a review from a team as a code owner December 13, 2024 13:26
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.28%. Comparing base (2829066) to head (c0843ee).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1574   +/-   ##
=======================================
  Coverage   80.28%   80.28%           
=======================================
  Files          41       41           
  Lines        1902     1902           
  Branches      445      444    -1     
=======================================
  Hits         1527     1527           
  Misses        346      346           
  Partials       29       29           
Files with missing lines Coverage Δ
src/lib/helpers.ts 97.93% <100.00%> (ø)
src/lib/included-files.ts 100.00% <100.00%> (ø)
src/lib/module.ts 81.25% <100.00%> (ø)

@samayer12 samayer12 enabled auto-merge December 13, 2024 16:05
@samayer12 samayer12 added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit f618e2b Dec 13, 2024
48 checks passed
@samayer12 samayer12 deleted the 1548 branch December 13, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

return types on module.ts, included-files.ts, helpers.ts
2 participants