-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: warn devs when their feature branches may be too large #1571
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1571 +/- ##
=======================================
Coverage 80.84% 80.84%
=======================================
Files 42 42
Lines 1952 1952
Branches 424 451 +27
=======================================
Hits 1578 1578
+ Misses 372 345 -27
- Partials 2 29 +27 |
@cmwylie19, what do you think about making the pre-push script an opt-in via an environment variable? We don't want to force everyone to work that way since it's highly-opinionated and hooks can be bypassed with |
Yeah that can work |
5cdb69e
to
297251d
Compare
Set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussed as a team, people who desire this can opt in
Description
Collectively, the Pepr team has reviewed some large PRs lately (e.g., #1262, #1543, #1539, #1396, #1402, #1407). We prefer several smaller PRs to reduce the amount of time spent in code-review and to encourage working in small chunks. This script is an example of a pre-push hook using Husky that warns devs when their branch may be too large.
This PR does not fulfill a need in the backlog, and does not need to be merged. Rather, it's offered as an example to how a Pepr developer might use a similar script for their local development.
Related Issue
None.
Type of change
Checklist before merging