-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: return types on src/lib/assets/index.ts src/lib/controller/index.ts src/lib/mutate-request.ts #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Case Wylie <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1515 +/- ##
==========================================
- Coverage 79.02% 78.97% -0.05%
==========================================
Files 40 40
Lines 1735 1736 +1
Branches 405 414 +9
==========================================
Hits 1371 1371
- Misses 334 335 +1
Partials 30 30
|
samayer12
reviewed
Dec 5, 2024
samayer12
reviewed
Dec 5, 2024
Co-authored-by: Sam Mayer <[email protected]>
samayer12
reviewed
Dec 5, 2024
Co-authored-by: Sam Mayer <[email protected]>
samayer12
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stricter typing to catch type errors in src/lib/assets/index.ts src/lib/controller/index.ts src/lib/mutate-request.ts
Related Issue
Fixes #1513
Relates to #
Type of change
Checklist before merging