Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: return types on src/lib/assets/index.ts src/lib/controller/index.ts src/lib/mutate-request.ts #1515

Merged
merged 7 commits into from
Dec 6, 2024

Conversation

cmwylie19
Copy link
Collaborator

Description

Stricter typing to catch type errors in src/lib/assets/index.ts src/lib/controller/index.ts src/lib/mutate-request.ts

Related Issue

Fixes #1513

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@cmwylie19 cmwylie19 requested a review from a team as a code owner December 5, 2024 15:30
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.97%. Comparing base (a6b6620) to head (f99b7e0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/controller/index.ts 0.00% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1515      +/-   ##
==========================================
- Coverage   79.02%   78.97%   -0.05%     
==========================================
  Files          40       40              
  Lines        1735     1736       +1     
  Branches      405      414       +9     
==========================================
  Hits         1371     1371              
- Misses        334      335       +1     
  Partials       30       30              
Files with missing lines Coverage Δ
src/lib/mutate-request.ts 100.00% <100.00%> (ø)
src/lib/controller/index.ts 10.40% <0.00%> (-0.09%) ⬇️

src/lib/mutate-request.ts Outdated Show resolved Hide resolved
src/lib/mutate-request.ts Outdated Show resolved Hide resolved
@cmwylie19 cmwylie19 enabled auto-merge December 6, 2024 03:13
@cmwylie19 cmwylie19 added this pull request to the merge queue Dec 6, 2024
@cmwylie19 cmwylie19 modified the milestones: v0.42.0, v0.43.0 Dec 6, 2024
Merged via the queue into main with commit 921b0b4 Dec 6, 2024
47 checks passed
@cmwylie19 cmwylie19 deleted the 1513 branch December 6, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

return types on src/lib/assets/index.ts src/lib/controller/index.ts src/lib/mutate-request.ts
2 participants