-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: resolve eslint warnings (max-statements, complexity) - src/lib/assets/index.ts
#1497
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1497 +/- ##
=======================================
Coverage 79.12% 79.12%
=======================================
Files 39 39
Lines 1720 1720
Branches 388 404 +16
=======================================
Hits 1361 1361
+ Misses 357 330 -27
- Partials 2 29 +27 |
src/lib/assets/index.ts
b5ff99a
to
be5f3a5
Compare
Got all the complexity warnings fixed and shrunk number of statements to just one more than the limit where I then stopped because any further statement squashing would have made the function more difficult to grok. This method has the (rather large) responsibility for laying out files on disk in a format that it doesn't own -- a helm chart's expected structure -- and that feels rather larger in scope than the |
Co-authored-by: Sam Mayer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussion points have been resolved, good work on addressing some complex code!
Describe what should be investigated or refactored
Refactor of
src/lib/assets/index.ts
to reduce complexity warnings:Additional context
In support of #1248