Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add typing support to regex-related adjudicators #1484

Closed
wants to merge 67 commits into from

Conversation

samayer12
Copy link
Collaborator

@samayer12 samayer12 commented Nov 22, 2024

Description

This PR adds typing support for regex-related adjudicators. Merge this in after #1402.

End to End Test:
(See Pepr Excellent Examples)

Related Issue

Relates to #1397, #1402

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.84%. Comparing base (38ece9e) to head (3e9c842).

Files with missing lines Patch % Lines
src/lib/capability.ts 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1484   +/-   ##
=======================================
  Coverage   80.84%   80.84%           
=======================================
  Files          42       42           
  Lines        1952     1952           
  Branches      424      424           
=======================================
  Hits         1578     1578           
  Misses        372      372           
  Partials        2        2           
Files with missing lines Coverage Δ
src/lib/filter/adjudicators/adjudicators.ts 98.46% <ø> (ø)
src/lib/capability.ts 94.90% <0.00%> (ø)

Copy link
Collaborator

@cmwylie19 cmwylie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change to the Pepr API that is in production and being used in delivery.

@samayer12 samayer12 self-assigned this Dec 6, 2024
@samayer12
Copy link
Collaborator Author

It has been awhile since this was created, we'll restart off of main since the journey tests are failing.

@samayer12 samayer12 closed this Dec 16, 2024
@samayer12 samayer12 deleted the 1397-type-regex-adjudicators branch December 16, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants