Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adr for undici and status corrections #1461

Merged
merged 4 commits into from
Nov 20, 2024
Merged

chore: adr for undici and status corrections #1461

merged 4 commits into from
Nov 20, 2024

Conversation

cmwylie19
Copy link
Collaborator

Description

Retro-active ADR for Undici Watch. The ADR is retro-active because of the urgency to implement a fix fast. It also updates other ADRs that have been accepted.

Related Issue

Fixes #1460

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@cmwylie19 cmwylie19 requested a review from a team as a code owner November 20, 2024 21:37
Signed-off-by: Case Wylie <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.55%. Comparing base (60be0d3) to head (25fcba3).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1461   +/-   ##
=======================================
  Coverage   78.55%   78.55%           
=======================================
  Files          36       36           
  Lines        1716     1716           
  Branches      386      411   +25     
=======================================
  Hits         1348     1348           
+ Misses        366      339   -27     
- Partials        2       29   +27     

see 7 files with indirect coverage changes

---- 🚨 Try these New Features:

@cmwylie19 cmwylie19 changed the title chore: ADR for undici and status corrections chore: adr for undici and status corrections Nov 20, 2024
Copy link
Collaborator

@btlghrants btlghrants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit. Nicely done.

@btlghrants btlghrants merged commit 5da1140 into main Nov 20, 2024
46 of 47 checks passed
@btlghrants btlghrants deleted the 1460 branch November 20, 2024 22:26
@cmwylie19 cmwylie19 added this to the v0.41.0 milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ADR on why we are changing node-fetch for 'undici'
2 participants