Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use consistent enum property names between related enums #1451

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

samayer12
Copy link
Collaborator

@samayer12 samayer12 commented Nov 20, 2024

Description

Property names on Event enums are not in upper-case, unlike the property names for Operation. These two enums are related, and it aids code readability for them to match each other's format (all caps).

End to End Test:
(See Pepr Excellent Examples)

Related Issue

Relates to #1397 and #1402

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@samayer12 samayer12 requested a review from a team as a code owner November 20, 2024 17:33
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.55%. Comparing base (83e0d88) to head (8414f28).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1451   +/-   ##
=======================================
  Coverage   78.55%   78.55%           
=======================================
  Files          36       36           
  Lines        1716     1716           
  Branches      386      410   +24     
=======================================
  Hits         1348     1348           
+ Misses        366      339   -27     
- Partials        2       29   +27     
Files with missing lines Coverage Δ
src/lib/capability.ts 94.90% <100.00%> (ø)
src/lib/enums.ts 100.00% <100.00%> (ø)
src/lib/filter/adjudicators.ts 100.00% <ø> (ø)
src/lib/watch-processor.ts 78.64% <100.00%> (ø)

... and 6 files with indirect coverage changes

---- 🚨 Try these New Features:

@samayer12 samayer12 changed the title Use consistent enum property names between related enums chore: use consistent enum property names between related enums Nov 20, 2024
@cmwylie19 cmwylie19 merged commit 60be0d3 into main Nov 20, 2024
46 of 48 checks passed
@cmwylie19 cmwylie19 deleted the enum-consistency branch November 20, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants