chore: new-filter and unit test covering cluster-scoped and group defined resources #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Case Wylie <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1417 +/- ##
==========================================
+ Coverage 78.37% 78.55% +0.17%
==========================================
Files 36 36
Lines 1702 1716 +14
Branches 379 386 +7
==========================================
+ Hits 1334 1348 +14
Misses 366 366
Partials 2 2
|
Signed-off-by: Case Wylie <[email protected]>
btlghrants
requested changes
Nov 13, 2024
Co-authored-by: Barrett <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
cmwylie19
commented
Nov 13, 2024
Signed-off-by: Case Wylie <[email protected]>
cmwylie19
changed the title
samayer12
reviewed
Nov 14, 2024
Signed-off-by: Case Wylie <[email protected]>
btlghrants
requested changes
Nov 15, 2024
Signed-off-by: Case Wylie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are running our unit tests on Pods mostly, we need more complex Kubernetes resources to test upon.
Related Issue
Fixes #1398
Relates to #
Type of change
Checklist before merging