Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): break up request adjudicator tests to separate file for readability #1408

Merged
merged 4 commits into from
Nov 13, 2024
Merged

chore(test): break up request adjudicator tests to separate file for readability #1408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f78935b
Break up request adjudicator tests to separate file for readability
samayer12 Nov 8, 2024
54b9454
Merge branch 'main' into 1397-part-3
samayer12 Nov 12, 2024
14ecfcc
Merge branch 'main' into 1397-part-3
samayer12 Nov 12, 2024
7a804e6
Merge branch 'main' into 1397-part-3
cmwylie19 Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
156 changes: 1 addition & 155 deletions src/lib/filter/adjudicators.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

import { expect, describe, it } from "@jest/globals";
import * as sut from "./adjudicators";
import { GroupVersionKind, KubernetesObject } from "kubernetes-fluent-client";
import { KubernetesObject } from "kubernetes-fluent-client";
import { AdmissionRequest, Binding, DeepPartial } from "../types";
import { Event, Operation } from "../enums";

Expand Down Expand Up @@ -379,37 +379,6 @@ describe("operationMatchesEvent", () => {
});
});

describe("declaredOperation", () => {
const defaultAdmissionRequest = {
uid: "some-uid",
kind: { kind: "a-kind", group: "a-group" },
resource: { group: "some-group", version: "some-version", resource: "some-resource" },
operation: undefined,
name: "some-name",
userInfo: {},
object: {},
};
//[ AdmissionRequest, result ]
it.each([
[{}, ""],
[{ operation: null }, ""],
[{ operation: "" }, ""],
[{ operation: "operation" }, "operation"],
[{ operation: Operation.CONNECT }, Operation.CONNECT],
[{ operation: Operation.CREATE }, Operation.CREATE],
[{ operation: Operation.UPDATE }, Operation.UPDATE],
[{ operation: Operation.DELETE }, Operation.DELETE],
])("given %j, returns '%s'", (given, expected) => {
const request = {
...defaultAdmissionRequest,
operation: ("operation" in given ? given.operation : (undefined as unknown as string)) as Operation,
};
const result = sut.declaredOperation(request);

expect(result).toEqual(expected);
});
});

describe("mismatchedEvent", () => {
//[ Binding, AdmissionRequest, result ]
it.each([
Expand Down Expand Up @@ -450,38 +419,6 @@ describe("mismatchedEvent", () => {
});
});

describe("declaredGroup", () => {
const defaultAdmissionRequest = {
uid: "some-uid",
kind: undefined,
group: "a-group",
resource: { group: "some-group", version: "some-version", resource: "some-resource" },
operation: Operation.CONNECT,
name: "some-name",
userInfo: {},
object: {},
};

//[ AdmissionRequest, result ]
it.each([
[{}, ""],
[{ kind: null }, ""],
[{ kind: {} }, ""],
[{ kind: { group: null } }, ""],
[{ kind: { group: "" } }, ""],
[{ kind: { group: "group" } }, "group"],
])("given %j, returns '%s'", (given, expected) => {
const request = {
...defaultAdmissionRequest,
kind: ("kind" in given ? given.kind : (undefined as unknown as string)) as GroupVersionKind,
};

const result = sut.declaredGroup(request);

expect(result).toEqual(expected);
});
});

describe("mismatchedGroup", () => {
//[ Binding, AdmissionRequest, result ]
it.each([
Expand All @@ -500,37 +437,6 @@ describe("mismatchedGroup", () => {
});
});

describe("declaredVersion", () => {
const defaultAdmissionRequest = {
uid: "some-uid",
kind: undefined,
group: "a-group",
resource: { group: "some-group", version: "some-version", resource: "some-resource" },
operation: Operation.CONNECT,
name: "some-name",
userInfo: {},
object: {},
};
//[ AdmissionRequest, result ]
it.each([
[{}, ""],
[{ kind: null }, ""],
[{ kind: {} }, ""],
[{ kind: { version: null } }, ""],
[{ kind: { version: "" } }, ""],
[{ kind: { version: "version" } }, "version"],
])("given %j, returns '%s'", (given, expected) => {
const request = {
...defaultAdmissionRequest,
kind: ("kind" in given ? given.kind : (undefined as unknown as string)) as GroupVersionKind,
};

const result = sut.declaredVersion(request);

expect(result).toEqual(expected);
});
});

describe("mismatchedVersion", () => {
//[ Binding, AdmissionRequest, result ]
it.each([
Expand All @@ -549,38 +455,6 @@ describe("mismatchedVersion", () => {
});
});

describe("declaredKind", () => {
const defaultAdmissionRequest = {
uid: "some-uid",
kind: undefined,
group: "a-group",
resource: { group: "some-group", version: "some-version", resource: "some-resource" },
operation: Operation.CONNECT,
name: "some-name",
userInfo: {},
object: {},
};

//[ AdmissionRequest, result ]
it.each([
[{}, ""],
[{ kind: null }, ""],
[{ kind: {} }, ""],
[{ kind: { kind: null } }, ""],
[{ kind: { kind: "" } }, ""],
[{ kind: { kind: "kind" } }, "kind"],
])("given %j, returns '%s'", (given, expected) => {
const request = {
...defaultAdmissionRequest,
kind: ("kind" in given ? given.kind : (undefined as unknown as string)) as GroupVersionKind,
};

const result = sut.declaredKind(request);

expect(result).toEqual(expected);
});
});

describe("mismatchedKind", () => {
//[ Binding, AdmissionRequest, result ]
it.each([
Expand All @@ -598,31 +472,3 @@ describe("mismatchedKind", () => {
expect(result).toEqual(expected);
});
});

describe("declaredUid", () => {
const defaultAdmissionRequest = {
uid: undefined,
kind: { kind: "a-kind", group: "a-group" },
group: "a-group",
resource: { group: "some-group", version: "some-version", resource: "some-resource" },
operation: Operation.CONNECT,
name: "some-name",
userInfo: {},
object: {},
};
//[ AdmissionRequest, result ]
it.each([
[{}, ""],
[{ uid: null }, ""],
[{ uid: "uid" }, "uid"],
])("given %j, returns '%s'", (given, expected) => {
const request = {
...defaultAdmissionRequest,
uid: ("uid" in given ? given.uid : (undefined as unknown as string)) as string,
};

const result = sut.declaredUid(request);

expect(result).toEqual(expected);
});
});
160 changes: 160 additions & 0 deletions src/lib/filter/adjudicators/requestAdjudicators.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,160 @@
// SPDX-License-Identifier: Apache-2.0
// SPDX-FileCopyrightText: 2023-Present The Pepr Authors

import { expect, describe, it } from "@jest/globals";
import * as sut from "../adjudicators";
import { Operation } from "../../enums";
import { GroupVersionKind } from "kubernetes-fluent-client";

describe("declaredUid", () => {
const defaultAdmissionRequest = {
uid: undefined,
kind: { kind: "a-kind", group: "a-group" },
group: "a-group",
resource: { group: "some-group", version: "some-version", resource: "some-resource" },
operation: Operation.CONNECT,
name: "some-name",
userInfo: {},
object: {},
};
//[ AdmissionRequest, result ]
it.each([
[{}, ""],
[{ uid: null }, ""],
[{ uid: "uid" }, "uid"],
])("given %j, returns '%s'", (given, expected) => {
const request = {
...defaultAdmissionRequest,
uid: ("uid" in given ? given.uid : (undefined as unknown as string)) as string,
};

const result = sut.declaredUid(request);

expect(result).toEqual(expected);
});
});

describe("declaredKind", () => {
const defaultAdmissionRequest = {
uid: "some-uid",
kind: undefined,
group: "a-group",
resource: { group: "some-group", version: "some-version", resource: "some-resource" },
operation: Operation.CONNECT,
name: "some-name",
userInfo: {},
object: {},
};
//[ AdmissionRequest, result ]
it.each([
[{}, ""],
[{ kind: null }, ""],
[{ kind: {} }, ""],
[{ kind: { kind: null } }, ""],
[{ kind: { kind: "" } }, ""],
[{ kind: { kind: "kind" } }, "kind"],
])("given %j, returns '%s'", (given, expected) => {
const request = {
...defaultAdmissionRequest,
kind: ("kind" in given ? given.kind : (undefined as unknown as string)) as GroupVersionKind,
};

const result = sut.declaredKind(request);

expect(result).toEqual(expected);
});
});

describe("declaredVersion", () => {
const defaultAdmissionRequest = {
uid: "some-uid",
kind: undefined,
group: "a-group",
resource: { group: "some-group", version: "some-version", resource: "some-resource" },
operation: Operation.CONNECT,
name: "some-name",
userInfo: {},
object: {},
};
//[ AdmissionRequest, result ]
it.each([
[{}, ""],
[{ kind: null }, ""],
[{ kind: {} }, ""],
[{ kind: { version: null } }, ""],
[{ kind: { version: "" } }, ""],
[{ kind: { version: "version" } }, "version"],
])("given %j, returns '%s'", (given, expected) => {
const request = {
...defaultAdmissionRequest,
kind: ("kind" in given ? given.kind : (undefined as unknown as string)) as GroupVersionKind,
};

const result = sut.declaredVersion(request);

expect(result).toEqual(expected);
});
});

describe("declaredGroup", () => {
const defaultAdmissionRequest = {
uid: "some-uid",
kind: undefined,
group: "a-group",
resource: { group: "some-group", version: "some-version", resource: "some-resource" },
operation: Operation.CONNECT,
name: "some-name",
userInfo: {},
object: {},
};
//[ AdmissionRequest, result ]
it.each([
[{}, ""],
[{ kind: null }, ""],
[{ kind: {} }, ""],
[{ kind: { group: null } }, ""],
[{ kind: { group: "" } }, ""],
[{ kind: { group: "group" } }, "group"],
])("given %j, returns '%s'", (given, expected) => {
const request = {
...defaultAdmissionRequest,
kind: ("kind" in given ? given.kind : (undefined as unknown as string)) as GroupVersionKind,
};

const result = sut.declaredGroup(request);

expect(result).toEqual(expected);
});
});

describe("declaredOperation", () => {
const defaultAdmissionRequest = {
uid: "some-uid",
kind: { kind: "a-kind", group: "a-group" },
resource: { group: "some-group", version: "some-version", resource: "some-resource" },
operation: undefined,
name: "some-name",
userInfo: {},
object: {},
};
//[ AdmissionRequest, result ]
it.each([
[{}, ""],
[{ operation: null }, ""],
[{ operation: "" }, ""],
[{ operation: "operation" }, "operation"],
[{ operation: Operation.CONNECT }, Operation.CONNECT],
[{ operation: Operation.CREATE }, Operation.CREATE],
[{ operation: Operation.UPDATE }, Operation.UPDATE],
[{ operation: Operation.DELETE }, Operation.DELETE],
])("given %j, returns '%s'", (given, expected) => {
const request = {
...defaultAdmissionRequest,
operation: ("operation" in given ? given.operation : (undefined as unknown as string)) as Operation,
};

const result = sut.declaredOperation(request);

expect(result).toEqual(expected);
});
});
Loading