Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unit tests for finalizer with user alias #1342

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Conversation

schaeferka
Copy link
Contributor

Description

The unit tests for capability.ts do not have test for finalizer with a user alias. We should add these tests to ensure that capability.ts is handling user provided alias with finalizer correctly.
...

End to End Test:

Related Issue

Fixes #1341

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [ x Other (security config, docs update, etc)

Checklist before merging

@schaeferka schaeferka self-assigned this Oct 28, 2024
@schaeferka schaeferka requested a review from a team as a code owner October 28, 2024 15:57
@schaeferka schaeferka linked an issue Oct 28, 2024 that may be closed by this pull request
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.64%. Comparing base (10fc531) to head (02a0c45).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1342   +/-   ##
=======================================
  Coverage   85.64%   85.64%           
=======================================
  Files          31       31           
  Lines        1449     1449           
  Branches      343      343           
=======================================
  Hits         1241     1241           
- Misses        190      206   +16     
+ Partials       18        2   -16     

see 4 files with indirect coverage changes

@cmwylie19 cmwylie19 merged commit 7260348 into main Oct 28, 2024
45 of 46 checks passed
@cmwylie19 cmwylie19 deleted the 1341-finalizer-tests branch October 28, 2024 16:17
@cmwylie19 cmwylie19 added this to the v0.39.0 milestone Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

chore: add capability finalizer tests with user provided alias
2 participants