Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix circular dependency between types and mutate-request #1332

Merged
merged 10 commits into from
Oct 25, 2024
Merged

Conversation

schaeferka
Copy link
Contributor

Description

We would like to remove the circular dependency between types.ts and mutate-request.ts
...

End to End Test:
(See Pepr Excellent Examples)

Related Issue

Fixes #

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@schaeferka schaeferka requested a review from a team as a code owner October 24, 2024 18:15
@schaeferka schaeferka self-assigned this Oct 24, 2024
@schaeferka schaeferka changed the title 1244 chore: fix circular dependency between types and mutate-request Oct 24, 2024
@schaeferka schaeferka changed the title chore: fix circular dependency between types and mutate-request chore: fix circular dependency between types and mutate-request Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.00%. Comparing base (2b0d353) to head (491cbf1).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1332   +/-   ##
=======================================
  Coverage   85.99%   86.00%           
=======================================
  Files          30       31    +1     
  Lines        1442     1443    +1     
  Branches      339      330    -9     
=======================================
+ Hits         1240     1241    +1     
  Misses        184      184           
  Partials       18       18           
Files with missing lines Coverage Δ
src/lib/adjudicators.ts 100.00% <100.00%> (ø)
src/lib/filter.ts 94.73% <100.00%> (ø)
src/lib/finalizer.ts 100.00% <100.00%> (ø)
src/lib/mutate-request.ts 100.00% <100.00%> (ø)
src/lib/mutate-types.ts 100.00% <100.00%> (ø)
src/lib/types.ts 100.00% <ø> (ø)
src/lib/validate-request.ts 100.00% <100.00%> (ø)

Copy link
Collaborator

@samayer12 samayer12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and we love net-deletions!

@schaeferka schaeferka enabled auto-merge (squash) October 24, 2024 22:27
@schaeferka schaeferka disabled auto-merge October 24, 2024 22:27
@cmwylie19 cmwylie19 merged commit 97c2845 into main Oct 25, 2024
48 checks passed
@cmwylie19 cmwylie19 deleted the 1244 branch October 25, 2024 12:45
@schaeferka schaeferka linked an issue Oct 25, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

chore: fix circular dependency between types and validate-request
3 participants