Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rbac overrides in package.json #1331

Merged
merged 39 commits into from
Oct 24, 2024
Merged

feat: rbac overrides in package.json #1331

merged 39 commits into from
Oct 24, 2024

Conversation

schaeferka
Copy link
Contributor

Description

We want to leverage package.json to defined RBAC settings that will work with RBAC and create an excellent example test.

Describe the solution you'd like
Given we want to create a reproducible way to generate scoped RBAC
When we define the RBAC in package.json and run a build
Then we have our customized RBAC
...

End to End Test:
(See Pepr Excellent Examples)

Related Issue

Fixes #814

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@schaeferka schaeferka added this to the v0.39.0 milestone Oct 24, 2024
@schaeferka schaeferka self-assigned this Oct 24, 2024
@schaeferka schaeferka requested a review from a team as a code owner October 24, 2024 17:36
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.99%. Comparing base (c1c0de7) to head (82b44c5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/assets/helm.ts 50.00% 1 Missing ⚠️
src/lib/assets/rbac.ts 93.75% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1331      +/-   ##
==========================================
+ Coverage   85.77%   85.99%   +0.21%     
==========================================
  Files          29       30       +1     
  Lines        1406     1442      +36     
  Branches      328      339      +11     
==========================================
+ Hits         1206     1240      +34     
- Misses        182      184       +2     
  Partials       18       18              
Files with missing lines Coverage Δ
src/lib/helpers.ts 97.19% <100.00%> (+0.04%) ⬆️
src/lib/module.ts 81.25% <ø> (ø)
src/lib/types.ts 100.00% <ø> (ø)
src/lib/assets/helm.ts 92.30% <50.00%> (-7.70%) ⬇️
src/lib/assets/rbac.ts 96.77% <93.75%> (ø)

Copy link
Collaborator

@cmwylie19 cmwylie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, tested with Helm, ZarfPackage and manifests with and without rbac

@cmwylie19 cmwylie19 merged commit 2b0d353 into main Oct 24, 2024
45 of 46 checks passed
@cmwylie19 cmwylie19 deleted the 814 branch October 24, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Have a way to create overrides for RBAC in a source file.
2 participants