-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rbac overrides in package.json #1331
Conversation
Co-authored-by: Case Wylie <[email protected]>
Co-authored-by: Case Wylie <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1331 +/- ##
==========================================
+ Coverage 85.77% 85.99% +0.21%
==========================================
Files 29 30 +1
Lines 1406 1442 +36
Branches 328 339 +11
==========================================
+ Hits 1206 1240 +34
- Misses 182 184 +2
Partials 18 18
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, tested with Helm, ZarfPackage and manifests with and without rbac
Description
We want to leverage package.json to defined RBAC settings that will work with RBAC and create an excellent example test.
Describe the solution you'd like
Given we want to create a reproducible way to generate scoped RBAC
When we define the RBAC in package.json and run a build
Then we have our customized RBAC
...
End to End Test:
(See Pepr Excellent Examples)
Related Issue
Fixes #814
Relates to #
Type of change
Checklist before merging