chore: soak interruptions for checkresync test #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Case Wylie <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
cmwylie19
commented
Oct 18, 2024
cmwylie19
commented
Oct 18, 2024
cmwylie19
commented
Oct 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1299 +/- ##
=======================================
Coverage 85.77% 85.77%
=======================================
Files 29 29
Lines 1406 1406
Branches 328 328
=======================================
Hits 1206 1206
- Misses 182 198 +16
+ Partials 18 2 -16 |
cmwylie19
commented
Oct 18, 2024
cmwylie19
commented
Oct 18, 2024
cmwylie19
commented
Oct 18, 2024
cmwylie19
commented
Oct 18, 2024
cmwylie19
commented
Oct 18, 2024
cmwylie19
commented
Oct 18, 2024
schaeferka
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds soak interrupts test that tests the branch where checkResync runs. CheckResync runs when the informer has not seen an event in the LAST_SEEN limit. Since our http2Watch is not dropping connections we need to create a new test to ensure this branch of the code works.
Related Issue
Fixes #1298
Relates to #
Type of change
Checklist before merging