Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deploy-time configurable alwaysIgnore.namespaces #1610

Open
mjnagel opened this issue Dec 20, 2024 · 1 comment · May be fixed by #1641 or #1617
Open

Allow deploy-time configurable alwaysIgnore.namespaces #1610

mjnagel opened this issue Dec 20, 2024 · 1 comment · May be fixed by #1641 or #1617
Assignees
Labels
enhancement New feature or request

Comments

@mjnagel
Copy link
Contributor

mjnagel commented Dec 20, 2024

Is your feature request related to a problem? Please describe.

Currently on uds-core we set 2 namespaces to ignore by default. In some environments these namespaces should not really be ignored (one is a dev namespace) and in other namespaces additional namespaces may need to be ignored (i.e. additional "system namespaces"). Currently these are configured at build time and we have not found an obvious way to allow this to be configured at deploy time.

Describe the solution you'd like

The current setting is templated into the webhook configuration under:

        - key: kubernetes.io/metadata.name
          operator: NotIn
          values:
            - kube-system
            - pepr-system

It would be a relatively easy change to allow this to be configured in the helm chart to append to/modify the list here. In the case of uds-core we could default this list to including the dev-stack, but via overrides at deploy time it could be modified.

Describe alternatives you've considered

  1. Make this the module author's responsibility - rather than filtering out with the webhook config, the module code could filter based on namespace.
  2. Identify an alternative path with zarf/etc that would be viable to modify this.
@mjnagel mjnagel added the enhancement New feature or request label Dec 20, 2024
@cmwylie19
Copy link
Collaborator

Been thinking about dynamic configuration for a while now. Currently do not have a CP/DP paradigm but it would enable more and more dynamic config. Thanks for the issue - we will consider what the best option would be to enable this type of behavior

@cmwylie19 cmwylie19 self-assigned this Jan 3, 2025
@cmwylie19 cmwylie19 moved this from 🆕 New to 🏗 In progress in Pepr Project Board Jan 3, 2025
github-merge-queue bot pushed a commit that referenced this issue Jan 6, 2025
… object (#1619)

## Description

CarriedNamespace did not account for Namespace objects which caused some
strange behaviors in #1610

After Fix:

```bash
[14:20:13.943] DEBUG (44989): Ignoring Watch Callback: Object carries namespace 'pepr-demo-2' but ignored namespaces include '["pepr-demo-2"]'.
```

## Related Issue

Fixes #1618 
<!-- or -->
Relates to #

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging
- [x] Unit,
[Journey](https://github.com/defenseunicorns/pepr/tree/main/journey),
[E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples),
[docs](https://github.com/defenseunicorns/pepr/tree/main/docs),
[adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or
updated as needed
- [x] [Contributor Guide
Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request)
followed

---------

Signed-off-by: Case Wylie <[email protected]>
Co-authored-by: Barrett <[email protected]>
@cmwylie19 cmwylie19 linked a pull request Jan 8, 2025 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🏗 In progress
2 participants