Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: src/lib/filter/filterNoMatchReason.ts #1584

Closed
btlghrants opened this issue Dec 16, 2024 · 1 comment · Fixed by #1585
Closed

refactor: src/lib/filter/filterNoMatchReason.ts #1584

btlghrants opened this issue Dec 16, 2024 · 1 comment · Fixed by #1585
Assignees
@btlghrants
Milestone
v0.42.2

Comments

@btlghrants
Copy link
Collaborator

btlghrants commented Dec 16, 2024 •
edited
Loading

Describe what should be investigated or refactored

Refactor of src/lib/filter/filterNoMatchReason.ts to reduce complexity warnings:

/pepr/src/lib/filter/filterNoMatchReason.ts
  32:8  warning  Function 'filterNoMatchReason' has a complexity of 13. Maximum allowed is 10  complexity

Additional context

In support of #1248
@btlghrants btlghrants converted this from a draft issue Dec 16, 2024
@btlghrants btlghrants self-assigned this Dec 16, 2024
@btlghrants btlghrants added this to the v0.42.2 milestone Dec 16, 2024
@btlghrants btlghrants mentioned this issue Dec 16, 2024
Merged
@btlghrants
Copy link
Collaborator Author

btlghrants commented Dec 16, 2024 •
edited
Loading

PR moves logic out of src/lib/filter/filterNoMatchReason.ts and into src/lib/filter/filter.ts (to match pattern established by shouldSkipRequest()) -- warning's gone, regardless.

@btlghrants btlghrants moved this from 🏗 In progress to 👀 In review in Pepr Project Board Dec 16, 2024
@btlghrants btlghrants moved this from 👀 In review to 🏗 In progress in Pepr Project Board Dec 17, 2024
@btlghrants btlghrants moved this from 🏗 In progress to 👀 In review in Pepr Project Board Dec 17, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 17, 2024
@btlghrants
refactor: resolve eslint warnings (complexity) - src/lib/filter/filte…
9aa2930 
…rNoMatchReason.ts (#1585)

### Describe what should be investigated or refactored

Refactor of `src/lib/filter/filterNoMatchReason.ts` to reduce complexity
warnings:
```
/pepr/src/lib/filter/filterNoMatchReason.ts
  32:8  warning  Function 'filterNoMatchReason' has a complexity of 13. Maximum allowed is 10  complexity
```

### Additional context
Fixes #1584 
In support of #1248
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Pepr Project Board Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@btlghrants btlghrants

Labels
None yet
Projects
Pepr Project Board
Archived in project
Milestone
v0.42.2
1 participant
@btlghrants