Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return types on storage.ts #1506

Closed
cmwylie19 opened this issue Dec 4, 2024 · 0 comments · Fixed by #1507
Closed

return types on storage.ts #1506

cmwylie19 opened this issue Dec 4, 2024 · 0 comments · Fixed by #1507
Assignees
Milestone

Comments

@cmwylie19
Copy link
Collaborator

Describe what should be investigated or refactored

As we work to make Pepr stronger typed, Storage is missing many return types.

pepr/src/lib/storage.ts
   15:8   warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
   19:8   warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
   23:8   warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
   83:3   warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
   87:3   warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
   99:3   warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
  107:3   warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
  115:3   warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
  119:3   warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
  131:3   warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
  157:3   warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
  178:15  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
  181:3   warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
  189:3   warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
  193:3   warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
  200:24  warning  Missing return type on function  @typescript-eslint/explicit-function-return-type
  209:3   warning  Missing return type on function  @typescript-eslint/explicit-function-return-type

Links to any relevant code

(optional) i.e. -

[![Pepr Documentation](https://img.shields.io/badge/docs--d25ba1)](./docs/README.md)

Additional context

Add any other context or screenshots about the technical debt here.

@cmwylie19 cmwylie19 added this to the v0.41.0 milestone Dec 4, 2024
@cmwylie19 cmwylie19 moved this from 🆕 New to 🏗 In progress in Pepr Project Board Dec 4, 2024
@cmwylie19 cmwylie19 self-assigned this Dec 4, 2024
@cmwylie19 cmwylie19 moved this from 🏗 In progress to 👀 In review in Pepr Project Board Dec 4, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 4, 2024
## Description

Adds return types to storage

## Related Issue

Fixes #1506 
<!-- or -->
Relates to #

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging
- [x] Unit,
[Journey](https://github.com/defenseunicorns/pepr/tree/main/journey),
[E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples),
[docs](https://github.com/defenseunicorns/pepr/tree/main/docs),
[adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or
updated as needed
- [x] [Contributor Guide
Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request)
followed

---------

Signed-off-by: Case Wylie <[email protected]>
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Pepr Project Board Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant