Tolerate existing circular deps

defenseunicorns · Oct 3, 2024 · 303d1ec · 303d1ec
1 parent 5cee957
commit 303d1ec
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 2 deletions.
diff --git a/.github/workflows/dependency-review.yml b/.github/workflows/dependency-review.yml
@@ -32,5 +32,15 @@ jobs:
       - name: 'Checkout Repository'
         uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
       - name: Circular Dependency Check
-        run: npx madge --circular --ts-config tsconfig.json --extensions ts,js src/
-        continue-on-error: true  
+        run: |
+          npx madge --circular --ts-config tsconfig.json --extensions ts,js src/ > circular-deps.log || true # Force exit 0 for post-processing
+          egrep -E "^\d+\).*" circular-deps.log > tmp.log && mv tmp.log circular-deps.log
+          cat circular-deps.log
+          if [ $(wc -l < circular-deps.log) -gt 18 ]; then
+            echo "circular-deps.log has more than 18 circular dependencies."
+            wc -l circular-deps.log
+            # exit 1
+          else
+            echo "circular-deps.log has 18 or fewer circular dependencies."
+            # exit 0
+          fi
diff --git a/circular-deps.log b/circular-deps.log
@@ -0,0 +1,18 @@
+1) lib/assets/index.ts > lib/assets/deploy.ts
+2) lib/assets/index.ts > lib/assets/deploy.ts > lib/assets/pods.ts
+3) lib/types.ts > lib/mutate-request.ts
+4) lib/types.ts > lib/validate-request.ts
+5) lib.ts > lib/capability.ts > lib/module.ts
+6) lib/capability.ts > lib/module.ts
+7) lib/capability.ts > lib/module.ts > lib/controller/index.ts
+8) lib/capability.ts > lib/module.ts > lib/controller/index.ts > lib/controller/store.ts
+9) lib/module.ts > lib/controller/index.ts
+10) lib/capability.ts > lib/module.ts > lib/controller/index.ts > lib/mutate-processor.ts
+11) lib/module.ts > lib/controller/index.ts > lib/mutate-processor.ts
+12) lib/capability.ts > lib/module.ts > lib/controller/index.ts > lib/validate-processor.ts
+13) lib/module.ts > lib/controller/index.ts > lib/validate-processor.ts
+14) lib/capability.ts > lib/module.ts > lib/watch-processor.ts
+15) lib/helpers.ts > sdk/sdk.ts > lib.ts > lib/capability.ts > lib/module.ts > lib/watch-processor.ts
+16) sdk/sdk.ts > lib.ts
+17) lib/assets/index.ts > lib/assets/deploy.ts > lib/assets/webhooks.ts
+18) lib/assets/index.ts > lib/assets/yaml.ts