-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): persist file upload status #967
Conversation
✅ Deploy Preview for leapfrogai-docs canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrewrisse, File Management notifications are working great! The Save button on the Edit/New Assistant page is disabled and I am unable to click it. This is on lf-04
Unable to replicate, can you explain how you got into this scenario |
I believe you were testing this on lf-04 when it did not have this branch deployed. I had to deploy a different story to lf-04 for a while yesterday morning. |
Description
Two parts:
Notes
If we need to show regular file upload (file-management page) error toasts, then the backend needs to implement: https://platform.openai.com/docs/api-reference/uploads
We do not currently have background processing enabled for file uploads, so the best we can do for realtime notifications is show a success toast when the new file is inserted into the file_objects table. On error, there is no realtime notification available.
Deployed on LF-04
Fixes #671
https://www.loom.com/share/e2da2a3f674a45bc8d94bce5f3ef4d4d?sid=75d0c91d-dedf-4a31-8b7f-b59efd5ebd48
Checklist before merging