Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): persist file upload status #967

Merged
merged 22 commits into from
Sep 6, 2024
Merged

Conversation

andrewrisse
Copy link
Contributor

@andrewrisse andrewrisse commented Aug 30, 2024

Description

Two parts:

  1. Notify user of successful file upload even when leaving file-management page
  2. Display special toast when vectorizing files for an assistant with those files' progress

Notes

If we need to show regular file upload (file-management page) error toasts, then the backend needs to implement: 
https://platform.openai.com/docs/api-reference/uploads
We do not currently have background processing enabled for file uploads, so the best we can do for realtime notifications is show a success toast when the new file is inserted into the file_objects table. On error, there is no realtime notification available.

Deployed on LF-04

Fixes #671

https://www.loom.com/share/e2da2a3f674a45bc8d94bce5f3ef4d4d?sid=75d0c91d-dedf-4a31-8b7f-b59efd5ebd48

Checklist before merging

@andrewrisse andrewrisse added the enhancement New feature or request label Aug 30, 2024
@andrewrisse andrewrisse self-assigned this Aug 30, 2024
Copy link

netlify bot commented Aug 30, 2024

Deploy Preview for leapfrogai-docs canceled.

Name Link
🔨 Latest commit c8daf81
🔍 Latest deploy log https://app.netlify.com/sites/leapfrogai-docs/deploys/66dafe8bb4ce750008cdcc30

@justinthelaw justinthelaw changed the title 671 persist file status feat(ui): persist file upload status Sep 4, 2024
@andrewrisse andrewrisse marked this pull request as ready for review September 4, 2024 20:58
@andrewrisse andrewrisse requested a review from a team as a code owner September 4, 2024 20:58
Copy link
Contributor

@gregclark-defenseunicorns gregclark-defenseunicorns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewrisse, File Management notifications are working great! The Save button on the Edit/New Assistant page is disabled and I am unable to click it. This is on lf-04

Screenshot 2024-09-05 at 8 30 40 AM

@andrewrisse
Copy link
Contributor Author

@andrewrisse, File Management notifications are working great! The Save button on the Edit/New Assistant page is disabled and I am unable to click it. This is on lf-04

Screenshot 2024-09-05 at 8 30 40 AM

Unable to replicate, can you explain how you got into this scenario

@andrewrisse
Copy link
Contributor Author

@andrewrisse, File Management notifications are working great! The Save button on the Edit/New Assistant page is disabled and I am unable to click it. This is on lf-04
Screenshot 2024-09-05 at 8 30 40 AM

Unable to replicate, can you explain how you got into this scenario

I believe you were testing this on lf-04 when it did not have this branch deployed. I had to deploy a different story to lf-04 for a while yesterday morning.

@andrewrisse andrewrisse merged commit cb0650d into main Sep 6, 2024
19 checks passed
@andrewrisse andrewrisse deleted the 671-persist-file-status branch September 6, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(ui) UI persists the status of uploaded files (e.g. processing, ready, error)
4 participants