First golang generation #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Runyon <[email protected]>
Signed-off-by: Tom Runyon <[email protected]>
|
I wonder if we should move the package a bit deeper into the folder hierarchy here, having a top level pkg/cmd feels a little weird with the Python code under leapfrog/ and model code under models/, maybe under api/ ? |
|
otherwise lgtm |
added 2 commits
June 22, 2023 06:42
Signed-off-by: Tom Runyon <[email protected]>
Signed-off-by: Tom Runyon <[email protected]>
gerred
approved these changes
Jun 22, 2023
added 2 commits
June 24, 2023 08:26
Signed-off-by: Tom Runyon <[email protected]>
Signed-off-by: Tom Runyon <[email protected]>
runyontr
commented
Jun 26, 2023
models/speech2text/whisper/main.py
Outdated
| import leapfrog | ||
| import logging | ||
|
|
||
| class Whisper(leapfrog.AudioService): |
There was a problem hiding this comment.
@gerred can you finish this implementation?
Signed-off-by: Tom Runyon <[email protected]>
Signed-off-by: Tom Runyon <[email protected]>
Signed-off-by: Tom Runyon <[email protected]>
Signed-off-by: Tom Runyon <[email protected]>
Signed-off-by: Tom Runyon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generating the golang clients for the proto services to jumpstart the API conversion as part of switching the API to golang.
blocked by #93