-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bring ui into monorepo #349
Conversation
✅ Deploy Preview for leapfrogai-docs canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doing some initial change requests since this is gonna be a chonky review
If Supabase is a resource we are sharing between the API DB and UI, do we need to move the Supabase directory up a level? Not totally sure how that works. |
That directory is for running Supabase locally with the UI although it does contain some migrations the frontend needs when setting up Supabase. I wonder if these could be moved up to a parent directory. @gerred I'm thinking consolating the supabase migrations and setup should be a separate issue once we have a sucessful deployment. I still need this in my section of the repo until that's in place |
Agreed on migrations later. |
Read through all the Svelte parts, looks like a really good start. We should consider something a little more robust for migrations. |
b96ab4f
to
891595d
Compare
* chore: bring ui into monorepo * chore: remove streaming api test, fix ui flicker * chore: additional tests * chore: additional tests with todos * fix: lower resource reqs/limits, remove sa * chore: more api tests * chore: more api tests 2 * fix: set resource limits to 0 * fix: delete .github dir under ui folder * chore: remove husky --------- Co-authored-by: Gerred Dillon <[email protected]> Signed-off-by: Andrew Risse <[email protected]>
* chore: bring ui into monorepo * chore: remove streaming api test, fix ui flicker * chore: additional tests * chore: additional tests with todos * fix: lower resource reqs/limits, remove sa * chore: more api tests * chore: more api tests 2 * fix: set resource limits to 0 * fix: delete .github dir under ui folder * chore: remove husky --------- Co-authored-by: Gerred Dillon <[email protected]> Signed-off-by: Andrew Risse <[email protected]>
* chore: bring ui into monorepo * chore: remove streaming api test, fix ui flicker * chore: additional tests * chore: additional tests with todos * fix: lower resource reqs/limits, remove sa * chore: more api tests * chore: more api tests 2 * fix: set resource limits to 0 * fix: delete .github dir under ui folder * chore: remove husky --------- Co-authored-by: Gerred Dillon <[email protected]> Signed-off-by: Andrew Risse <[email protected]>
* chore: bring ui into monorepo * chore: remove streaming api test, fix ui flicker * chore: additional tests * chore: additional tests with todos * fix: lower resource reqs/limits, remove sa * chore: more api tests * chore: more api tests 2 * fix: set resource limits to 0 * fix: delete .github dir under ui folder * chore: remove husky --------- Co-authored-by: Gerred Dillon <[email protected]>
* chore: bring ui into monorepo * chore: remove streaming api test, fix ui flicker * chore: additional tests * chore: additional tests with todos * fix: lower resource reqs/limits, remove sa * chore: more api tests * chore: more api tests 2 * fix: set resource limits to 0 * fix: delete .github dir under ui folder * chore: remove husky --------- Co-authored-by: Gerred Dillon <[email protected]>
* chore: bring ui into monorepo * chore: remove streaming api test, fix ui flicker * chore: additional tests * chore: additional tests with todos * fix: lower resource reqs/limits, remove sa * chore: more api tests * chore: more api tests 2 * fix: set resource limits to 0 * fix: delete .github dir under ui folder * chore: remove husky --------- Co-authored-by: Gerred Dillon <[email protected]>
Integrates the "new UI (lfaiui) into the monorepo.
New naming convention is "leapfrogai-ui"
Includes Keycloak code that will not work until Supabase is deployed in our clusters.
We will leave leapfrog-demo deployed as is since it does not use Keycloak yet.
closes #344
closes #307