This repository has been archived by the owner on Jul 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Zarf deploy-time GPU configuration #28
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
justinthelaw
commented
Feb 1, 2024
•
edited
Loading
edited
- Collapses everything into 1 image for CPU and GPU support
- Zarf deployment allocated GPU based on GPU_ENABLED flag
- Fixes for README and Deps
justinthelaw
requested review from
gerred,
YrrepNoj,
gphorvath and
a team
as code owners
February 1, 2024 01:37
gphorvath
previously approved these changes
Feb 1, 2024
gphorvath
previously approved these changes
Feb 1, 2024
YrrepNoj
suggested changes
Feb 1, 2024
gphorvath
previously approved these changes
Feb 1, 2024
YrrepNoj
suggested changes
Feb 6, 2024
YrrepNoj
reviewed
Feb 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
misc comments and thoughts <3
YrrepNoj
approved these changes
Feb 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.