220 remove selected state for section headers in nav drawer list #221
Conversation
…ed appStatesStore to only track currentRoute now.
…d route transform function to makeLinkText().
✅ Deploy Preview for unicorn-ui ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
…moved style block of ListSubheader.svelte since style is controlled by parent container (i.e. list or drawer); ListSubheader Props now of type BoxProps<HTMLHeadingElement>
… for height and vertical alignment.
|
uui/src/lib/Drawer/Drawer.svelte
Outdated
| .drawer.mdc-drawer .mdc-deprecated-list-group__subheader { | ||
| color: var(--on-background); | ||
| color: rgba(255, 255, 255, 0.7); |
There was a problem hiding this comment.
This has to be a css var to work on both themes. I believe it already exists in the palette.
There was a problem hiding this comment.
Also are we documenting these changes in Drawer? These really should just be website changes and not necessary involve the components
There was a problem hiding this comment.
I don't know if we should be hardcoding the width here as that is something the consumer should be doing. In the case of the drawer.
There was a problem hiding this comment.
I didn't see a corresponding color in the default palettes originally, although text-primary-on-background is close (.87 instead of .7 opacity). I guess i should check the hex colors again to make sure on of those isn't the correct one.
The thing i found was that mdc targets the subheader in the drawer and turns the color really dark ( rgba(0,0,0,.6) ) and that overrides whatever color the subheader is set to. I figured overriding their override as the default style shipped with the drawer component would be the right idea, but if you think that's the wrong direction i'm cool with yanking that and just overriding it for the website.
Yeah you're right about the width. I think i was just setting defaults because the original figma for Drawer shows 320 as well.
|
@Madeline-UX i'm wondering if something's off between what you're seeing and what I'm seeing. I'm still seeing the hover state for the items in the drawer. The hover state is really dark in dark-mode, though, which is the case on the current release as well. So maybe I just need to fix that hover color. Also, the figma I think you're referencing (https://www.figma.com/file/aNnt9Ip7IFTs9hnfqrYGl4/Unicorn-UI?type=design&node-id=108-14353&t=iMeXWcDQIgdewqwV-0) shows them both with elevation of 2. Sorry if that's the wrong design. |
… get box shadow to overshadow drawer.
…lte; made app logo link back to home route.
…r correct logo depending on selected theme mode.
…n website drawer.
…e the svelte kit goto() func for navigation on click.
…purpose after switching to goto() for navigation; made app logo only box with goto for on:click and on:keydown.
No description provided.